Allow building buildx from source#99
Merged
crazy-max merged 1 commit intodocker:masterfrom Jul 2, 2021
Merged
Conversation
b592f11 to
f258f34
Compare
crazy-max
commented
Jun 30, 2021
src/buildx.ts
Outdated
Comment on lines
135
to
150
Member
Author
There was a problem hiding this comment.
Binary will be cached. Atm remote ref sha is used as cache key. ${repo}-${sha} would be safer imo but it's fine in the meantime.
0b22624 to
ec29cee
Compare
5775af3 to
5e75885
Compare
tonistiigi
reviewed
Jul 1, 2021
Member
tonistiigi
left a comment
There was a problem hiding this comment.
Overall LGTM but the build-ref name is not great. Maybe buildx-source? Theoretically, we could also just use the version field and detect if it is a URL to a git repo.
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Member
Author
Ok I've changed the |
tonistiigi
approved these changes
Jul 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #98
I made some changes from what we said in #98. Now buildx will be built on-the-fly against the reference passed to
build-refinput. Here is a workflow:Run: https://github.com/docker/setup-buildx-action/runs/2963153312?check_suite_focus=true#step:3:94
cc @tonistiigi
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com