-
Notifications
You must be signed in to change notification settings - Fork 183
Allow building buildx from source #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b592f11
to
f258f34
Compare
src/buildx.ts
Outdated
return tc.cacheFile( | ||
`${outFolder}/buildx`, | ||
context.osPlat == 'win32' ? 'docker-buildx.exe' : 'docker-buildx', | ||
'buildx', | ||
sha | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Binary will be cached. Atm remote ref sha is used as cache key. ${repo}-${sha}
would be safer imo but it's fine in the meantime.
0b22624
to
ec29cee
Compare
5775af3
to
5e75885
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM but the build-ref
name is not great. Maybe buildx-source
? Theoretically, we could also just use the version field and detect if it is a URL to a git repo.
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Ok I've changed the |
Closes #98
I made some changes from what we said in #98. Now buildx will be built on-the-fly against the reference passed to
build-ref
input. Here is a workflow:Run: https://github.com/docker/setup-buildx-action/runs/2963153312?check_suite_focus=true#step:3:94
cc @tonistiigi
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com