New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make use of the "pullImage" parameter of node.Create method #222

Merged
merged 2 commits into from Jan 7, 2015

Conversation

Projects
None yet
3 participants
@mountkin
Contributor

mountkin commented Jan 6, 2015

The 'pullImage' parameter of node.Create method is not used currently.

make use of the "pullImage" parameter of node.Create method
Signed-off-by: mountkin <mountkin@gmail.com>
@aluzzardi

This comment has been minimized.

Contributor

aluzzardi commented Jan 6, 2015

Thanks!

I know that the entire Create function is not tested at all, but would you mind adding a test for this?

You could do it by using a mock client in node_test.go (there are already a few examples on how to achieve this).

add test cases for node.Create method
Signed-off-by: mountkin <mountkin@gmail.com>
@mountkin

This comment has been minimized.

Contributor

mountkin commented Jan 7, 2015

Hi, @aluzzardi
The test is added.

@aluzzardi

This comment has been minimized.

Contributor

aluzzardi commented Jan 7, 2015

Awesome! Thank you!

aluzzardi added a commit that referenced this pull request Jan 7, 2015

Merge pull request #222 from mountkin/master
make use of the "pullImage" parameter of node.Create method

@aluzzardi aluzzardi merged commit 322c547 into docker:master Jan 7, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@vieux vieux modified the milestone: Swarm Beta 0.1.0 Jan 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment