New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swarmctl deploy fails silently on service yaml files #537

Closed
aaronlehmann opened this Issue May 5, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@aaronlehmann
Collaborator

aaronlehmann commented May 5, 2016

Running swarmctl deploy -f on a file without a services top-level key, such as a service definition that should be used with swarmctl service create -f, does nothing. There is no error message or log message. It simply does not create a service.

There should probably be an error message if there's no top-level services key.

@aluzzardi

This comment has been minimized.

Show comment
Hide comment
@aluzzardi

aluzzardi May 5, 2016

Contributor

Agree with the error if there are no services.

I also think service create -f has to go away. IMO, there’s deploy which takes yml files and service create is the low-level command which only accepts flags.

Right now we have two file formats: with top-level services and without which is super confusing.

Contributor

aluzzardi commented May 5, 2016

Agree with the error if there are no services.

I also think service create -f has to go away. IMO, there’s deploy which takes yml files and service create is the low-level command which only accepts flags.

Right now we have two file formats: with top-level services and without which is super confusing.

@stevvooe

This comment has been minimized.

Show comment
Hide comment
@stevvooe

stevvooe Jun 9, 2016

Contributor

This isn't really relevant anymore.

Contributor

stevvooe commented Jun 9, 2016

This isn't really relevant anymore.

@stevvooe stevvooe closed this Jun 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment