New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert code to use connectionbroker package #1851

Merged
merged 1 commit into from Jan 10, 2017

Conversation

Projects
None yet
4 participants
@aaronlehmann
Collaborator

aaronlehmann commented Jan 9, 2017

By using connectionbroker instead of using remotes directly, subsystems
like the agent can connect directly to the local manager when running on
a node that acts as a manager. This avoids the need for the manager to
expose a TCP port at all times.

@aaronlehmann

This comment has been minimized.

Show comment
Hide comment
@aaronlehmann
Collaborator

aaronlehmann commented Jan 9, 2017

@aaronlehmann aaronlehmann referenced this pull request Jan 9, 2017

Merged

Allow managers not to expose a remote API port #1826

6 of 6 tasks complete
}
}(ready)
}

This comment has been minimized.

@dperny

dperny Jan 9, 2017

Member

is this the bit that all of this change was made to refactor out?

@dperny

dperny Jan 9, 2017

Member

is this the bit that all of this change was made to refactor out?

This comment has been minimized.

@aaronlehmann

aaronlehmann Jan 9, 2017

Collaborator

This change makes connections to the local manager use a unix socket or similar local connection (via connectionbroker) instead of connecting over TCP. As a consequence, this code, which finds the manager's IP address and adds it to the Remotes list to bootstrap Remotes, isn't necessary.

@aaronlehmann

aaronlehmann Jan 9, 2017

Collaborator

This change makes connections to the local manager use a unix socket or similar local connection (via connectionbroker) instead of connecting over TCP. As a consequence, this code, which finds the manager's IP address and adds it to the Remotes list to bootstrap Remotes, isn't necessary.

This comment has been minimized.

@dperny

dperny Jan 9, 2017

Member

Ok, I see.

@dperny

dperny Jan 9, 2017

Member

Ok, I see.

@dperny

This comment has been minimized.

Show comment
Hide comment
@dperny

dperny Jan 9, 2017

Member

This all looks good to me.

Member

dperny commented Jan 9, 2017

This all looks good to me.

@dongluochen

This comment has been minimized.

Show comment
Hide comment
@dongluochen

dongluochen Jan 9, 2017

Contributor

LGTM

Contributor

dongluochen commented Jan 9, 2017

LGTM

Show outdated Hide outdated manager/manager.go Outdated
@cyli

This comment has been minimized.

Show comment
Hide comment
@cyli

cyli Jan 10, 2017

Contributor

LGTM

Contributor

cyli commented Jan 10, 2017

LGTM

Convert code to use connectionbroker package
By using connectionbroker instead of using remotes directly, subsystems
like the agent can connect directly to the local manager when running on
a node that acts as a manager. This avoids the need for the manager to
expose a TCP port at all times.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>

@aaronlehmann aaronlehmann merged commit 69ea950 into docker:master Jan 10, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/project 54.70% (target 0.00%)
Details
dco-signed All commits are signed

@aaronlehmann aaronlehmann deleted the aaronlehmann:use-connectionbroker branch Jan 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment