New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allocator: Fix stuck tasks at startup #1938

Merged
merged 1 commit into from Feb 8, 2017

Conversation

Projects
None yet
4 participants
@aaronlehmann
Collaborator

aaronlehmann commented Feb 8, 2017

If the allocator starts up and sees a task in the NEW state that doesn't
need allocations, it should move it to PENDING immediately.

There was code in place for this but it wasn't actually updating the
task's state. The task would get stuck and never get assigned.

ping @cyli

allocator: Fix stuck tasks at startup
If the allocator starts up and sees a task in the NEW state that doesn't
need allocations, it should move it to PENDING immediately.

There was code in place for this but it wasn't actually updating the
task's state. The task would get stuck and never get assigned.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>

@aaronlehmann aaronlehmann modified the milestones: 1.13.1, 1.13.2 Feb 8, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Feb 8, 2017

Codecov Report

Merging #1938 into master will decrease coverage by -0.04%.

@@            Coverage Diff             @@
##           master    #1938      +/-   ##
==========================================
- Coverage   54.15%   54.11%   -0.04%     
==========================================
  Files         108      108              
  Lines       18544    18536       -8     
==========================================
- Hits        10042    10031      -11     
+ Misses       7284     7275       -9     
- Partials     1218     1230      +12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed384f3...1c6c9f1. Read the comment docs.

codecov-io commented Feb 8, 2017

Codecov Report

Merging #1938 into master will decrease coverage by -0.04%.

@@            Coverage Diff             @@
##           master    #1938      +/-   ##
==========================================
- Coverage   54.15%   54.11%   -0.04%     
==========================================
  Files         108      108              
  Lines       18544    18536       -8     
==========================================
- Hits        10042    10031      -11     
+ Misses       7284     7275       -9     
- Partials     1218     1230      +12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed384f3...1c6c9f1. Read the comment docs.

@LK4D4

LK4D4 approved these changes Feb 8, 2017

LGTM

@cyli

This comment has been minimized.

Show comment
Hide comment
@cyli

cyli Feb 8, 2017

Contributor

LGTM, thanks for fixing so quickly!

Contributor

cyli commented Feb 8, 2017

LGTM, thanks for fixing so quickly!

@cyli cyli merged commit ce8e78a into docker:master Feb 8, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/project 54.11% (target 0%)
Details
dco-signed All commits are signed

@aaronlehmann aaronlehmann deleted the aaronlehmann:allocator-stuck-tasks branch Feb 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment