New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global orchestrator reconcileServices should look at desired state only #1957

Merged
merged 1 commit into from Feb 15, 2017

Conversation

Projects
None yet
3 participants
@dongluochen
Contributor

dongluochen commented Feb 15, 2017

Global orchestrator reconcileServices should look at desired state only to avoid creating multiple tasks.

Signed-off-by: Dong Chen dongluo.chen@docker.com

Global orchestrator reconcileServices should look at desired state to…
… avoid adding multiple tasks.

Signed-off-by: Dong Chen <dongluo.chen@docker.com>

@dongluochen dongluochen added this to the 1.13.2 milestone Feb 15, 2017

@dongluochen

This comment has been minimized.

Show comment
Hide comment
@dongluochen
Contributor

dongluochen commented Feb 15, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Feb 15, 2017

Codecov Report

Merging #1957 into bump_v1.13.2 will decrease coverage by -4.96%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           bump_v1.13.2   #1957      +/-   ##
===============================================
- Coverage         60.26%   55.3%   -4.96%     
===============================================
  Files                75     102      +27     
  Lines             11903   17116    +5213     
===============================================
+ Hits               7173    9466    +2293     
- Misses             3910    6498    +2588     
- Partials            820    1152     +332

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4264d39...e6f7020. Read the comment docs.

codecov-io commented Feb 15, 2017

Codecov Report

Merging #1957 into bump_v1.13.2 will decrease coverage by -4.96%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           bump_v1.13.2   #1957      +/-   ##
===============================================
- Coverage         60.26%   55.3%   -4.96%     
===============================================
  Files                75     102      +27     
  Lines             11903   17116    +5213     
===============================================
+ Hits               7173    9466    +2293     
- Misses             3910    6498    +2588     
- Partials            820    1152     +332

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4264d39...e6f7020. Read the comment docs.

@aaronlehmann

This comment has been minimized.

Show comment
Hide comment
@aaronlehmann

aaronlehmann Feb 15, 2017

Collaborator

LGTM

Collaborator

aaronlehmann commented Feb 15, 2017

LGTM

@aaronlehmann aaronlehmann merged commit 00e6dde into docker:bump_v1.13.2 Feb 15, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/project 55.3% (target 0%)
Details
dco-signed All commits are signed

@aaronlehmann aaronlehmann modified the milestone: 1.13.2 Feb 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment