New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updater: Decrease default monitoring period #1967

Merged
merged 1 commit into from Feb 24, 2017

Conversation

Projects
None yet
4 participants
@aaronlehmann
Collaborator

aaronlehmann commented Feb 17, 2017

The updater monitors a tasks after they start to make sure they don't
fail immediately. The default time interval for this is 30s. However,
this is a bit long for synchronous updates to wait. Reduce it to 5s.
Users who would like a longer monitoring period should specify their own
value, or ideally use a health check in the service definition.

updater: Decrease default monitoring period
The updater monitors a tasks after they start to make sure they don't
fail immediately. The default time interval for this is 30s. However,
this is a bit long for synchronous updates to wait. Reduce it to 5s.
Users who would like a longer monitoring period should specify their own
value, or ideally use a health check in the service definition.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Feb 17, 2017

Codecov Report

Merging #1967 into master will increase coverage by 0.9%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #1967     +/-   ##
=========================================
+ Coverage   53.57%   54.48%   +0.9%     
=========================================
  Files         109      108      -1     
  Lines       18897    18587    -310     
=========================================
+ Hits        10125    10128      +3     
+ Misses       7541     7235    -306     
+ Partials     1231     1224      -7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea0cd1e...bc74a25. Read the comment docs.

codecov-io commented Feb 17, 2017

Codecov Report

Merging #1967 into master will increase coverage by 0.9%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #1967     +/-   ##
=========================================
+ Coverage   53.57%   54.48%   +0.9%     
=========================================
  Files         109      108      -1     
  Lines       18897    18587    -310     
=========================================
+ Hits        10125    10128      +3     
+ Misses       7541     7235    -306     
+ Partials     1231     1224      -7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea0cd1e...bc74a25. Read the comment docs.

@dongluochen

This comment has been minimized.

Show comment
Hide comment
@dongluochen

dongluochen Feb 17, 2017

Contributor

LGTM

Contributor

dongluochen commented Feb 17, 2017

LGTM

@dperny

This comment has been minimized.

Show comment
Hide comment
@dperny

dperny Feb 21, 2017

Member

Looks fine to me.

Member

dperny commented Feb 21, 2017

Looks fine to me.

@dperny

This comment has been minimized.

Show comment
Hide comment
@dperny

dperny Feb 21, 2017

Member

Should this impact performance at all, actually?

Member

dperny commented Feb 21, 2017

Should this impact performance at all, actually?

@aaronlehmann

This comment has been minimized.

Show comment
Hide comment
@aaronlehmann

aaronlehmann Feb 21, 2017

Collaborator

It shouldn't really impact performance. The main user-visible impact is that "update state" will switch to "complete" 5 seconds after updating the last task (if all goes well), instead of 30 seconds after. Right now this is a relatively mundane detail, but the WIP PR I have open in docker that shows progress bars for updates makes it a much bigger deal.

Collaborator

aaronlehmann commented Feb 21, 2017

It shouldn't really impact performance. The main user-visible impact is that "update state" will switch to "complete" 5 seconds after updating the last task (if all goes well), instead of 30 seconds after. Right now this is a relatively mundane detail, but the WIP PR I have open in docker that shows progress bars for updates makes it a much bigger deal.

@aaronlehmann aaronlehmann merged commit 7b7b440 into docker:master Feb 24, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/project 54.48% (target 0%)
Details
dco-signed All commits are signed

@aaronlehmann aaronlehmann deleted the aaronlehmann:default-monitoring-period branch Feb 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment