New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allocator: Remove deleted networks from the unallocated set #2019

Merged
merged 1 commit into from Mar 9, 2017

Conversation

Projects
None yet
3 participants
@aaronlehmann
Collaborator

aaronlehmann commented Mar 8, 2017

This looks like an oversight. Networks may have been kept in this set
forever after deletion.

cc @alexmavr @yongtang @aboch

allocator: Remove deleted networks from the unallocated set
This looks like an oversight. Networks may have been kept in this set
forever after deletion.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>

@aaronlehmann aaronlehmann added this to the 17.03.1 milestone Mar 8, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Mar 8, 2017

Codecov Report

Merging #2019 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2019      +/-   ##
==========================================
+ Coverage   53.66%   53.69%   +0.03%     
==========================================
  Files         109      109              
  Lines       18991    18992       +1     
==========================================
+ Hits        10191    10198       +7     
+ Misses       7578     7566      -12     
- Partials     1222     1228       +6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4762bc...5f52c14. Read the comment docs.

codecov bot commented Mar 8, 2017

Codecov Report

Merging #2019 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2019      +/-   ##
==========================================
+ Coverage   53.66%   53.69%   +0.03%     
==========================================
  Files         109      109              
  Lines       18991    18992       +1     
==========================================
+ Hits        10191    10198       +7     
+ Misses       7578     7566      -12     
- Partials     1222     1228       +6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4762bc...5f52c14. Read the comment docs.

@aboch

This comment has been minimized.

Show comment
Hide comment
@aboch

aboch Mar 8, 2017

Looks good to me

aboch commented Mar 8, 2017

Looks good to me

@aluzzardi

This comment has been minimized.

Show comment
Hide comment
@aluzzardi

aluzzardi Mar 9, 2017

Contributor

LGTM

Contributor

aluzzardi commented Mar 9, 2017

LGTM

@aaronlehmann aaronlehmann merged commit a5eb9c0 into docker:master Mar 9, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/project 53.69% (target 0%)
Details
dco-signed All commits are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment