New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] Error on cluster spec name change #2454

Merged
merged 1 commit into from Nov 19, 2017

Conversation

Projects
None yet
3 participants
@nishanttotla
Contributor

nishanttotla commented Nov 18, 2017

Cherry-pick #2436.

git cherry-pick -s -x 0b078d10da563bd8c1d4f3a795a81a5d2dbf5232

Cherry-pick was clean.

Error on cluster spec name change.
Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>
(cherry picked from commit 0b078d1)
Signed-off-by: Nishant Totla <nishanttotla@gmail.com>
@nishanttotla

This comment has been minimized.

Show comment
Hide comment
@nishanttotla
Contributor

nishanttotla commented Nov 18, 2017

@anshulpundir

This comment has been minimized.

Show comment
Hide comment
@anshulpundir

anshulpundir Nov 18, 2017

Contributor

Thx for doing this! @nishanttotla

Contributor

anshulpundir commented Nov 18, 2017

Thx for doing this! @nishanttotla

@thaJeztah

LGTM

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Nov 18, 2017

Member

Can someone restart CI?

Member

thaJeztah commented Nov 18, 2017

Can someone restart CI?

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 19, 2017

Codecov Report

Merging #2454 into bump_v17.09 will decrease coverage by 5.14%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           bump_v17.09    #2454      +/-   ##
===============================================
- Coverage        65.36%   60.22%   -5.15%     
===============================================
  Files               80      128      +48     
  Lines            14477    26170   +11693     
===============================================
+ Hits              9463    15761    +6298     
- Misses            4241     9036    +4795     
- Partials           773     1373     +600

codecov bot commented Nov 19, 2017

Codecov Report

Merging #2454 into bump_v17.09 will decrease coverage by 5.14%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           bump_v17.09    #2454      +/-   ##
===============================================
- Coverage        65.36%   60.22%   -5.15%     
===============================================
  Files               80      128      +48     
  Lines            14477    26170   +11693     
===============================================
+ Hits              9463    15761    +6298     
- Misses            4241     9036    +4795     
- Partials           773     1373     +600
@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Nov 19, 2017

Member

All green now!

Member

thaJeztah commented Nov 19, 2017

All green now!

@nishanttotla nishanttotla merged commit cd9dbfe into docker:bump_v17.09 Nov 19, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/project 60.22% (target 0%)
Details
dco-signed All commits are signed

@nishanttotla nishanttotla deleted the nishanttotla:error-cluster-spec-name-change-17.09 branch Nov 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment