New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] Provide custom gRPC dialer to override default proxy dialer (#2419) #2457

Merged
merged 1 commit into from Nov 20, 2017

Conversation

Projects
None yet
3 participants
@thaJeztah
Member

thaJeztah commented Nov 20, 2017

Cherry-pick of #2419 for 17.09

git checkout -b 17.09-backport-proxy upstream/bump_v17.09
git cherry-pick -s -S -x 312be5983e2d2f01f0cbcc99d027b28433256705

(cherry picked from commit 312be59)

ping @anshulpundir @nishanttotla PTAL

Provide custom gRPC dialer to override default proxy dialer (#2419)
Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>
(cherry picked from commit 312be59)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 20, 2017

Codecov Report

Merging #2457 into bump_v17.09 will decrease coverage by 0.14%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           bump_v17.09    #2457      +/-   ##
===============================================
- Coverage         60.2%   60.05%   -0.15%     
===============================================
  Files              128      128              
  Lines            26170    26174       +4     
===============================================
- Hits             15755    15720      -35     
- Misses            9033     9064      +31     
- Partials          1382     1390       +8

codecov bot commented Nov 20, 2017

Codecov Report

Merging #2457 into bump_v17.09 will decrease coverage by 0.14%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           bump_v17.09    #2457      +/-   ##
===============================================
- Coverage         60.2%   60.05%   -0.15%     
===============================================
  Files              128      128              
  Lines            26170    26174       +4     
===============================================
- Hits             15755    15720      -35     
- Misses            9033     9064      +31     
- Partials          1382     1390       +8

@anshulpundir anshulpundir merged commit b40ffde into docker:bump_v17.09 Nov 20, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/project 60.05% (target 0%)
Details
dco-signed All commits are signed

@thaJeztah thaJeztah deleted the thaJeztah:17.09-backport-proxy branch Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment