New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 17.12] Added required call to allocate VIPs when endpoints are restored #2474

Merged
merged 2 commits into from Dec 18, 2017

Conversation

Projects
None yet
4 participants
@abhi
Member

abhi commented Dec 18, 2017

Opening a new PR to get things moving. The original back port PR #2472

balrajsingh added some commits Dec 6, 2017

Addressing duplicate IP issue on ingress network
On leader change or leader reboot the restore logic in the allocator
was allocating overlapping IP address for VIPs and Endpoints in the
ingress network.  The fix added as part of this commit ensures
that during restore we allocate the existing VIP and endpoint.

Signed-off-by: Balraj Singh <balrajsingh@ieee.org>
Added unit test TestAllocatorRestoreForDuplicateIPs
Signed-off-by: Balraj Singh <balrajsingh@ieee.org>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Dec 18, 2017

Codecov Report

Merging #2474 into bump_v17.12 will decrease coverage by 0.08%.
The diff coverage is 0%.

@@               Coverage Diff               @@
##           bump_v17.12    #2474      +/-   ##
===============================================
- Coverage         61.8%   61.72%   -0.09%     
===============================================
  Files              128      128              
  Lines            21107    21109       +2     
===============================================
- Hits             13045    13029      -16     
- Misses            6664     6668       +4     
- Partials          1398     1412      +14

codecov bot commented Dec 18, 2017

Codecov Report

Merging #2474 into bump_v17.12 will decrease coverage by 0.08%.
The diff coverage is 0%.

@@               Coverage Diff               @@
##           bump_v17.12    #2474      +/-   ##
===============================================
- Coverage         61.8%   61.72%   -0.09%     
===============================================
  Files              128      128              
  Lines            21107    21109       +2     
===============================================
- Hits             13045    13029      -16     
- Misses            6664     6668       +4     
- Partials          1398     1412      +14
@thaJeztah

LGTM (not a maintainer)

@abhi

This comment has been minimized.

Show comment
Hide comment
@abhi

abhi Dec 18, 2017

Member

@dperny can you PTAL ?

Member

abhi commented Dec 18, 2017

@dperny can you PTAL ?

@dperny

This comment has been minimized.

Show comment
Hide comment
@dperny

dperny Dec 18, 2017

Member

LGTM

Member

dperny commented Dec 18, 2017

LGTM

@dperny dperny merged commit 2e6f892 into docker:bump_v17.12 Dec 18, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/project 61.72% (target 0%)
Details
dco-signed All commits are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment