New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.12] Fix task reaper not cleaning up COMPLETE tasks #2477

Merged
merged 1 commit into from Dec 19, 2017

Conversation

Projects
None yet
3 participants
@seemethere

seemethere commented Dec 19, 2017

Tasks in the complete state were not cleaned up because the task reaper
was only looking at task.Status.State >= api.TaskStateShutdown, but the
COMPLETE state (api.TaskStateCompleted) is the actual "first" terminal
state.

Added a test for the initialization stage of the task repear. This runs
the logic of which tasks to clean up through its paces, but doesn't test
the run-time logic of the task reaper (it's ability to respond to
updates to tasks).

Cherry-pick of #2473

Cherry pick does apply cleanly

Signed-off-by: Drew Erny drew.erny@docker.com
(cherry picked from commit e5b3107)
Signed-off-by: Eli Uriegas seemethere101@gmail.com

Fix task reaper not cleaning up COMPLETE tasks
Tasks in the complete state were not cleaned up because the task reaper
was only looking at task.Status.State >= api.TaskStateShutdown, but the
COMPLETE state (api.TaskStateCompleted) is the actual "first" terminal
state.

Added a test for the initialization stage of the task repear. This runs
the logic of which tasks to clean up through its paces, but doesn't test
the run-time logic of the task reaper (it's ability to respond to
updates to tasks).

Signed-off-by: Drew Erny <drew.erny@docker.com>
(cherry picked from commit e5b3107)
Signed-off-by: Eli Uriegas <seemethere101@gmail.com>
@seemethere

This comment has been minimized.

Show comment
Hide comment
@seemethere

seemethere commented Dec 19, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Dec 19, 2017

Codecov Report

Merging #2477 into bump_v17.12 will decrease coverage by 0.07%.
The diff coverage is 50%.

@@               Coverage Diff               @@
##           bump_v17.12    #2477      +/-   ##
===============================================
- Coverage        61.71%   61.63%   -0.08%     
===============================================
  Files              128      129       +1     
  Lines            21109    21232     +123     
===============================================
+ Hits             13028    13087      +59     
- Misses            6676     6736      +60     
- Partials          1405     1409       +4

codecov bot commented Dec 19, 2017

Codecov Report

Merging #2477 into bump_v17.12 will decrease coverage by 0.07%.
The diff coverage is 50%.

@@               Coverage Diff               @@
##           bump_v17.12    #2477      +/-   ##
===============================================
- Coverage        61.71%   61.63%   -0.08%     
===============================================
  Files              128      129       +1     
  Lines            21109    21232     +123     
===============================================
+ Hits             13028    13087      +59     
- Misses            6676     6736      +60     
- Partials          1405     1409       +4
@stevvooe

This comment has been minimized.

Show comment
Hide comment
@stevvooe

stevvooe Dec 19, 2017

Contributor

LGTM

Contributor

stevvooe commented Dec 19, 2017

LGTM

@stevvooe stevvooe merged commit 7598f7a into docker:bump_v17.12 Dec 19, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/project 61.63% (target 0%)
Details
dco-signed All commits are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment