Increase grpc max recv message size #2775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increases the maximum recieved message size for gRPC client connections to math.MaxInt32. This means that large controlapi List requests will be proxied correctly. Signed-off-by: Drew Erny <drew.erny@docker.com>
dperny
force-pushed
the
increase-max-recv-msg
branch
from
c6dfd6c
to
25c6d44
Compare
|
@dperny if this codeline is only accessible behind an api that has the proper creds, then i think the increase of the max message size is ok |
|
Looks like this only affects the connections between the managers. Also, this is reverting back grpc to the same behavior as previous releases. These help mitigate the risk somewhat @andrewhsu |
anshulpundir
approved these changes
Oct 31, 2018
Codecov Report
@@ Coverage Diff @@
## master #2775 +/- ##
=========================================
+ Coverage 61.97% 62% +0.02%
=========================================
Files 137 137
Lines 22047 22050 +3
=========================================
+ Hits 13664 13672 +8
+ Misses 6912 6906 -6
- Partials 1471 1472 +1 |
|
nitpick: update the comment in the code to something along the lines of #2775 (comment) |
This was referenced Oct 31, 2018
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Nov 1, 2018
Changes included; - moby/swarmkit#2735 Assign secrets individually to each task - moby/swarmkit#2759 Adding a new `Deallocator` component - moby/swarmkit#2738 Add additional info for secret drivers - moby/swarmkit#2775 Increase grpc max recv message size - addresses moby#37941 - addresses moby#37997 - follow-up to moby#38103 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker/docker-ce
that referenced
this pull request
Nov 12, 2018
Changes included; - moby/swarmkit#2735 Assign secrets individually to each task - moby/swarmkit#2759 Adding a new `Deallocator` component - moby/swarmkit#2738 Add additional info for secret drivers - moby/swarmkit#2775 Increase grpc max recv message size - addresses moby/moby#37941 - addresses moby/moby#37997 - follow-up to moby/moby#38103 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: be3843c8c8fb30b4a604dae9d0dad3d393db717c Component: engine
adhulipa
pushed a commit
to adhulipa/docker
that referenced
this pull request
Apr 11, 2019
Changes included; - moby/swarmkit#2735 Assign secrets individually to each task - moby/swarmkit#2759 Adding a new `Deallocator` component - moby/swarmkit#2738 Add additional info for secret drivers - moby/swarmkit#2775 Increase grpc max recv message size - addresses moby#37941 - addresses moby#37997 - follow-up to moby#38103 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipping the usual boilerplate, because this is a kludge, everyone involved knows its a kludge, and we'll revert it in the next release.
Increases the maximum recieved message size for gRPC client connections to math.MaxInt32. This means that large controlapi
Listrequests will be proxied correctly.