New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows-style line endings in start.sh #126

Closed
ndarilek opened this Issue Aug 26, 2015 · 6 comments

Comments

Projects
None yet
4 participants
@ndarilek

ndarilek commented Aug 26, 2015

Maybe this has to do with me running Cygwin rather than Mingw and Cygwin's bash attempting to run start.sh. I got this error:

./start.sh: line 2: $'\r': command not found

Running dos2unix on the file makes this error go away.

@jmorganca

This comment has been minimized.

Contributor

jmorganca commented Aug 27, 2015

Thanks for the issue.

dos2unix doesn't seem to change the file for me, and I can run it in cygwin.

Which version of the Toolbox are you running?

@jmorganca jmorganca added this to the 1.8.1c milestone Aug 28, 2015

@SvenDowideit

This comment has been minimized.

Contributor

SvenDowideit commented Aug 30, 2015

The worst thing is that some git clones will convert to Windows line endings, and then doing a docker build will fail to run scripts..

@SvenDowideit

This comment has been minimized.

Contributor

SvenDowideit commented Aug 30, 2015

I recal this working in b2d, but i really can't remember what we did.

@SvenDowideit

This comment has been minimized.

Contributor

SvenDowideit commented Aug 30, 2015

for building Docker, the best thing is to avoid the issue by setting git config --global core.autocrlf input which makes git clone using unix endings, and converts windows endings on commit

@jmorganca

This comment has been minimized.

Contributor

jmorganca commented Aug 31, 2015

This should be fixed in 1.8.1c. Thank again!

@jmorganca jmorganca closed this Aug 31, 2015

@elleache

This comment has been minimized.

elleache commented Sep 21, 2016

Not fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment