Decide a standard coding style #115

Closed
lextm opened this Issue Mar 24, 2013 · 4 comments

Comments

Projects
None yet
3 participants
Member

lextm commented Mar 24, 2013

The current code base experiences the following issues on coding style,

  • Mixed tabs/spaces
  • Mixed indentation
  • Other minor issues
    We might work together to decide a standard style for this project, and generate a StyleCop setting to guard the code base.

Some time before we ship 3.0 release, we might perform a deep cleanup and apply the new style to all source files.

Member

lextm commented Mar 24, 2013

My proposed style setting is the one I used for previous projects,

https://github.com/lextm/sharpsnmplib/blob/master/SharpSnmpLib/Settings.SourceAnalysis

I am open to any suggestions.

Owner

roken commented Mar 26, 2013

I agree with there being whitespace issues and would strongly vote for 4 space indentation per level. Tabs are the worst.

tgiphil commented Mar 26, 2013

I prefer tabs over spaces since it gives control to the user over the indentation length (2 spaces, 4 spaces, etc.)

roken pushed a commit that referenced this issue Apr 14, 2013

Ryan Rastedt
#115 - Remove use of tabs for indentation
There's religion, politics, and tabs vs spaces.  Regardless of your view
it should be consistent, and since I'm implementing the change we're
going spaces.  If we need justification beyond my personal preference,
this is the default in Visual Studio.

lextm added a commit that referenced this issue Apr 21, 2013

#115 - Remove use of tabs for indentation
There's religion, politics, and tabs vs spaces.  Regardless of your view
it should be consistent, and since I'm implementing the change we're
going spaces.  If we need justification beyond my personal preference,
this is the default in Visual Studio.

fxbit added a commit to fxbit/dockpanelsuite that referenced this issue Feb 14, 2014

#115 - Remove use of tabs for indentation
There's religion, politics, and tabs vs spaces.  Regardless of your view
it should be consistent, and since I'm implementing the change we're
going spaces.  If we need justification beyond my personal preference,
this is the default in Visual Studio.

@lextm lextm removed this from the 3.0.0 milestone Jul 6, 2016

Member

lextm commented Jul 19, 2017

For coding style I think we gradually move to Visual Studio default. New changes should follow that, while we bit by bit update the old lines.

@lextm lextm closed this Jul 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment