Visual Studio 2012 Skin #59

Closed
wvdvegt opened this Issue Sep 12, 2012 · 12 comments

4 participants

@wvdvegt

Hi

Does anyone alrady wrote a skin to have DockPanelSuite look like the dark VS2010 type of docking?

@roken
DockPanel Suite member

(Related to #19)

@lextm
DockPanel Suite member

It is less ideal to hack on VS2005* files, as they are for VS2005 style, which we could like to keep for backward compatibility.

The new style should use VS2012* names and live in new source files.

The patch will be reviewed and evaluated on a dedicated branch once we have time.

@lextm lextm was assigned Feb 20, 2013
@lextm
DockPanel Suite member

Should also include #97 #98 #99 #100 #101 and #103

But it is not obvious whether #96 is also related.

@lextm
DockPanel Suite member

I just committed a new change set that includes most of the patches in a new branch. Will evaluate how much effort is required to complete the new skin. The sample project has been updated to show this new skin.

7d430b7

@lextm
DockPanel Suite member

Made some changes heavily on the old design, so as to allow customization on DockWindow and SplitterControl. The new change set is

21fa895

@roken please review if you are OK with the interface changes I made.

I think we might design some new classes to better encapsulate skins/themes, as in the current design it is not obvious to know what are all places you can customize. I will later post another change set to show my experimental design and implementation.

@han6man can you perform a review on this branch? I attempted to include most of your changes but I should have missed something. Your review can help identify the missing pieces as you are the original contributor.

@lextm
DockPanel Suite member

#98 is now integrated in 3f4526b.

@lextm
DockPanel Suite member

Wrote a blog post about how to write new themes, http://www.lextm.com/2013/03/dockpanel-suite-how-to-write-new-theme.html. Later will finalize it and copy to the Cookbook on Wiki.

@lextm
DockPanel Suite member

There are a few minor issues about this new theme,
1. Splitter elements do not highlight themselves when clicked. (compared to VS2008, 2010, and 2012).
1. Vertical splitter elements do not render as gradient. (compared to VS2012).
There might be more which I could not detect during the integration. So fine tuning the new theme requires more efforts in the future.

@lextm
DockPanel Suite member

Just noticed a CodePlex project, https://dockpanel2012.codeplex.com/ Not sure if that's where the patches @han6man submitted come from.

@lextm
DockPanel Suite member

A review on https://dockpanel2012.codeplex.com has finished, and the previous patches submitted by @han6man are in fact coming from that CodePlex project.

Now all needed changes of the VS 2012 Light theme have been added to

https://github.com/dockpanelsuite/dockpanelsuite/commits/development_3.0

I have also tuned several settings (font, color, and width of tab elements) to achieve better compliance with Visual Studio 2012.

@lextm lextm closed this May 1, 2013
@lextm lextm was assigned May 1, 2013
@lextm
DockPanel Suite member
@lextm lextm modified the milestone: 2.10.0, 3.0.0 Jul 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment