Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of capybara-email in Capybara 2 #10

Closed
wants to merge 1 commit into from

Conversation

woahdae
Copy link

@woahdae woahdae commented Aug 30, 2012

Capybara 2 does not define 'url' on the selenium driver, which
previously Capybara::Email::Driver#follow relied on. Fortunately,
Capybara::Session#visit is more robust in Capybara 2, and we can rely on
it to attach the correct full path to relative urls instead of
leveraging the previous 'url' method.

Capybara 2 does not define 'url' on the selenium driver, which
previously Capybara::Email::Driver#follow relied on. Fortunately,
Capybara::Session#visit is more robust in Capybara 2, and we can rely on
it to attach the correct full path to relative urls instead of
leveraging the previous 'url' method.
@travisbot
Copy link

This pull request passes (merged e2aeda0 into 37f21ed).

@bcardarella
Copy link
Contributor

I think the way I'd prefer to handle this is release a 1.0 version of capybara-email and then start a 2.0 version that supports Capybara 2.0. The capybara version dependency in the gemspec can be set to '~> 1 for 1.0 and '~> 2 for 2.0. Thoughts?

@woahdae
Copy link
Author

woahdae commented Jan 16, 2013

Late to the party, but sounds good!

@woahdae woahdae deleted the capybara2 branch January 16, 2013 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants