Skip to content
This repository

Mail and Capybara are runtime requirements #11

Merged
merged 2 commits into from over 1 year ago

2 participants

Nick Gauthier Brian Cardarella
Nick Gauthier

The gemspec only shows them as development dependencies. When I added it to a project, Mail was not defined, since it was not required yet by the project.

I've changed mail and capybara in the gemspec as well as requiring the libraries in the gem's source.

Tests pass and fixed my problem.

Brian Cardarella
Owner

Can you version lock capybara to ~> 2.0

Master branch will be for Caybara 2 which requires some incompatible changes to how capybara-email works.

If you'd like to also submit a PR for 1-0-stable that has capybara version locked to ~> 1.0 I can do a gem release today (not sure which version you're using)

Nick Gauthier

locked it to beta4. I'm running against capybara-email off my fork, which is fine for now. When capy goes 2.0 stable you can release capybara-email 2.0 stable. Fine for me.

Brian Cardarella bcardarella merged commit 1d2401c into from
Brian Cardarella bcardarella closed this
Brian Cardarella
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
4  capybara-email.gemspec
@@ -14,9 +14,9 @@ Gem::Specification.new do |gem|
14 14
   gem.require_paths = ['lib']
15 15
   gem.version       = Capybara::Email::VERSION
16 16
 
17  
-  gem.add_development_dependency 'mail'
  17
+  gem.add_dependency 'mail'
  18
+  gem.add_dependency 'capybara', '~> 2.0.0.beta4'
18 19
   gem.add_development_dependency 'actionmailer'
19  
-  gem.add_development_dependency 'capybara', '2.0.0.beta2'
20 20
   gem.add_development_dependency 'bourne'
21 21
   gem.add_development_dependency 'rspec'
22 22
   gem.add_development_dependency 'rake'
2  lib/capybara-email.rb
... ...
@@ -1,3 +1,5 @@
  1
+require 'capybara'
  2
+require 'mail'
1 3
 module Capybara
2 4
   autoload :Email, 'capybara/email'
3 5
 end
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.