Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug when table do not exists (join) #164

Closed
wants to merge 6 commits into from

Conversation

gastonmorixe
Copy link

When table do not exists we should check before.

@edpaget
Copy link
Collaborator

edpaget commented May 18, 2015

Looks pretty good to me, just a couple small things. Can you add a test case for this code, and also squash your commits into a single one?

@@ -5,15 +5,17 @@ module Visitors
class PostgreSQL
private

def visit_Array o, a
def visit_Array o, a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please kill the whitespace at the end of this line

@danmcclain
Copy link
Contributor

Agree with @edpaget on this PR

@@ -3,10 +3,6 @@ source 'https://rubygems.org'
# Specify your gem's dependencies in postgres_ext.gemspec
gemspec
unless ENV['CI']
if RUBY_PLATFORM =~ /java/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danmcclain I'm going to clean this PR up and merge it since it seems useful. Do you want this part in the final result?

@edpaget
Copy link
Collaborator

edpaget commented May 11, 2016

Merged here: f88cbf3

@edpaget edpaget closed this May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants