More postgres features #17

Merged
merged 1 commit into from Oct 3, 2012

Conversation

Projects
None yet
2 participants
Contributor

kbrock commented Oct 3, 2012

Hey Dan / Brian,

about to hit version 0.01 of postgres_gis.

Needed to tweak a few things in postgres_ext to give me some extension points.

  1. Need extra index types (got this from a current rails 4.0 patch)
  2. Need extension point to add column spec properties

Let me know if you want me to pull this into multiple requests, or want me to take a different approach.

--Keenan

Contributor

kbrock commented Oct 3, 2012

locally ran in mri 1.9 and jruby(1.9)

Contributor

danmcclain commented Oct 3, 2012

This all looks really good. I just had a question about the comments in schema_dumper (you say 2.3, but I think you mean 3.2). Could you squash these commits into one commit?

Contributor

kbrock commented Oct 3, 2012

thanks - done

Contributor

danmcclain commented Oct 3, 2012

@kbrock Want to add an entry to the changelog detailing the changes? Once that is done, I'll merge this in. Thanks for the contributions

@kbrock kbrock add ability to specify index_type and where in creating / dumping ind…
…exes.

add extension point for enhancing column_specs
ff7ee60

@danmcclain danmcclain added a commit that referenced this pull request Oct 3, 2012

@danmcclain danmcclain Merge pull request #17 from kbrock/more_postgres_features
More postgres features
2a8908f

@danmcclain danmcclain merged commit 2a8908f into DockYard:master Oct 3, 2012

Contributor

danmcclain commented Oct 3, 2012

Thanks @kbrock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment