Skip to content

Conversation

@vagenas
Copy link
Collaborator

@vagenas vagenas commented Mar 14, 2025

  • Introduced inline DocTag
  • Using new serialization framework code seems to automatically fix some bugs around list handling

Still todo:

  • Handle page breaks
  • fix nested list items
  • centralize token labels
  • Fix page headers & footnotes not showing up in new export
  • reconcile internally blocked item types (e.g. caption) with label parameter
  • fix OTSL location tokens
  • Propagate & use all parameters
  • Move all relevant code out of DoclingDocument
  • Adapt any moved code to framework & its conventions
  • Iron out any misalignment with previous exporters
  • cache excluded refs
  • clarify escaping e.g. HTML
  • add tests covering labels / layers params

@mergify
Copy link

mergify bot commented Mar 14, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

🟢 Require two reviewer for test updates

Wonderful, this rule succeeded.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

@vagenas vagenas force-pushed the add-doctags-serializer branch from ea04269 to 4c4be7c Compare March 18, 2025 08:38
vagenas added 3 commits March 19, 2025 08:55
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
@vagenas vagenas force-pushed the add-doctags-serializer branch from 6a3e796 to c872092 Compare March 19, 2025 07:57
vagenas added 6 commits March 19, 2025 10:51
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
vagenas added 5 commits March 20, 2025 09:57
…sses

Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
vagenas added 4 commits March 21, 2025 10:13
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
@vagenas vagenas marked this pull request as ready for review March 21, 2025 12:13
@vagenas vagenas requested a review from cau-git March 21, 2025 12:21
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
@vagenas vagenas requested a review from PeterStaar-IBM March 21, 2025 12:30
@vagenas vagenas merged commit 1f4d57e into main Mar 21, 2025
8 checks passed
@vagenas vagenas deleted the add-doctags-serializer branch March 21, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants