fix: Automatic transformation of output cells bbox coord origin defined by input in get_cells_in_bbox #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…same as input bbox.coord_origin when requesting get_cells_in_bbox Signed-off-by: Maksym Lysak <mly@zurich.ibm.com>
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
maxmnemonic
changed the title
Signed-off-by: Maksym Lysak <mly@zurich.ibm.com>
maxmnemonic
force-pushed
the
dev/page_cells_in_bbox_fullauto_origin
branch
from
3ba1632 to
814f78a
Compare
…e a copy Signed-off-by: Maksym Lysak <mly@zurich.ibm.com>
maxmnemonic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added automatic transformation of page cell_bbox coord origin to the same as input bbox.coord_origin when requesting get_cells_in_bbox.
Current behavior - is to throw error and stop if the input coord_origin differs from backend page coord_origin, which is almost always when get_cells_in_bbox is used in a client code of Docling. This PR fixes it, and presents resulting cells pre-transformed into the same origin as input crop bbox.
This small fix removes the overhead in the client code we put in Docling.