Skip to content

feat: add HTML serializer #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Apr 10, 2025
Merged

feat: add HTML serializer #232

merged 34 commits into from
Apr 10, 2025

Conversation

@PeterStaar-IBM
Copy link
Contributor

@PeterStaar-IBM PeterStaar-IBM commented Apr 3, 2025

No description provided.

@PeterStaar-IBM PeterStaar-IBM self-assigned this Apr 3, 2025
@mergify
Copy link

mergify bot commented Apr 3, 2025 •
edited
Loading

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

🟢 Require two reviewer for test updates

Wonderful, this rule succeeded.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

@PeterStaar-IBM PeterStaar-IBM added the enhancement New feature or request label Apr 8, 2025
@PeterStaar-IBM PeterStaar-IBM marked this pull request as ready for review April 8, 2025 14:01
cau-git
cau-git reviewed Apr 8, 2025
View reviewed changes
dolfim-ibm
dolfim-ibm reviewed Apr 8, 2025
View reviewed changes
dolfim-ibm
dolfim-ibm reviewed Apr 8, 2025
View reviewed changes
@PeterStaar-IBM PeterStaar-IBM mentioned this pull request Apr 9, 2025
Closed
vagenas
vagenas reviewed Apr 9, 2025
View reviewed changes
Copy link
Collaborator

@vagenas vagenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PeterStaar-IBM various improvements proposed with #242 e.g.:

  • including span information in the returned SerializationResults
  • caption handling in case of floating text items (e.g. code item)
  • caption handling in case holding element is excluded

@PeterStaar-IBM @vagenas
iunitial attempt at HTML serializer
ea6be4e 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
first version, to be tested thoroughly
4207c77 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
added the new test
91d9729 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
rewrote carefully the export-to-html into new framework
b81d66a 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
fixed the inline list-items
1d1c91a 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
added the inline code
2d3ee27 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
migrated the table html code
2835935 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
updated the picture HTML serializer
7fde69c 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
updated the html for Form and KeyValue
6dc4ffa 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
first version of KeyValue serialisation
3d22a3e 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
fixed the key-value and form-region and added the GraphData serializer
31d61d2 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
need to do some mypy work now
8f954ed 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
passed the mypy
7df6526 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
added the get_excluded_refs function to obtain proper serialization
2389bb4 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
enabled the captions
af3f88c 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
removed empty lists
1b2a4ae 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
added initial split view and customised styles
ab440c7 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
PeterStaar-IBM and others added 16 commits April 9, 2025 17:19
@PeterStaar-IBM @vagenas
cleaned up, now waiting for page-indices propagationg
d23f80e 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
updated the styles and parameters with split_page
f264133 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
propagated the parameter split_page_view
91a2d33 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
first fully working version
21957a4 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
removed the prints
7b7ac6d 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
fixed the tests
81c0fa5 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
fixed the tests
77b035c 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
fixed the tests for html export
b4af30d 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
removed dead code
1ef37b8 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
updated the test output
1bcbbae 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
fixed the tests
a27b4dd 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
reformatted the code
9f41dd9 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
rename parameter tag to class_name
885b973 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
added serializers to table and picture
c10963c 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM @vagenas
removed dead code
df4b897 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@vagenas
various HTML serialization improvements (#242)
0c6174a 
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
@vagenas vagenas force-pushed the dev/add-html-serializer branch from 626fb72 to 0c6174a Compare April 9, 2025 15:20
vagenas
vagenas previously approved these changes Apr 9, 2025
View reviewed changes
@PeterStaar-IBM PeterStaar-IBM changed the title feat: initial attempt at HTML serializer feat: add HTML serializer Apr 9, 2025
@PeterStaar-IBM
added enum for different output styles
7add617 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
cau-git
cau-git approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@cau-git cau-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@PeterStaar-IBM PeterStaar-IBM merged commit 5d40600 into main Apr 10, 2025
8 checks passed
@PeterStaar-IBM PeterStaar-IBM deleted the dev/add-html-serializer branch April 10, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dolfim-ibm dolfim-ibm dolfim-ibm left review comments

@vagenas vagenas vagenas approved these changes

@cau-git cau-git cau-git approved these changes

@maxmnemonic maxmnemonic Awaiting requested review from maxmnemonic

Assignees

@PeterStaar-IBM PeterStaar-IBM

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@PeterStaar-IBM @vagenas @cau-git @dolfim-ibm