feat: Chart tabular data serialization for HTML serializer #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksym Lysak <mly@zurich.ibm.com>
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 Require two reviewer for test updatesWonderful, this rule succeeded.When test data is updated, we require two reviewers
|
Signed-off-by: Maksym Lysak <mly@zurich.ibm.com>
maxmnemonic
changed the title
Signed-off-by: Maksym Lysak <mly@zurich.ibm.com>
maxmnemonic
changed the title
maxmnemonic
changed the title
cau-git
previously approved these changes
Apr 15, 2025
maxmnemonic
changed the title
Signed-off-by: Maksym Lysak <mly@zurich.ibm.com>
…rt serialization into html and md Signed-off-by: Maksym Lysak <mly@zurich.ibm.com>
maxmnemonic
changed the title
vagenas
approved these changes
Apr 15, 2025
cau-git
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of chart serializer in HTML (same functionality as in Markdown), checks if Image has chart tabular data attached to it, and renders table with extracted values underneath.
Can be controlled by
enable_chart_tablesparameter (True by default)Added tests for chart loading from
DocTagsand for chart data serialization intoHTMLandMarkdown