Skip to content

Conversation

@ceberam
Copy link
Collaborator

@ceberam ceberam commented Aug 18, 2025

This PR adds a fix to the HTML serializer: a forward slash is added to the <meta> tag. Even though <meta> is a void element and thus the forward slash is optional, we propose to add the forward slash to support XML-based parsing libraries such us xml.dom.minidom.

This PR replaces #355

Fixes #354

15mbp and others added 2 commits August 18, 2025 11:22
See issue #354 on docling-project/docling-core

Signed-off-by: 15mbp <100952997+15mbp@users.noreply.github.com>
Signed-off-by: Cesar Berrospi Ramis <75900930+ceberam@users.noreply.github.com>
@github-actions
Copy link
Contributor

DCO Check Passed

Thanks @ceberam, all your commits are properly signed off. 🎉

@mergify
Copy link

mergify bot commented Aug 18, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

🟢 Require two reviewer for test updates

Wonderful, this rule succeeded.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

Copy link
Contributor

@dolfim-ibm dolfim-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ceberam ceberam requested a review from cau-git August 19, 2025 07:52
@ceberam ceberam merged commit 23badf2 into main Aug 19, 2025
12 checks passed
@ceberam ceberam deleted the fix/html-forward-slashes branch August 19, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No forward slash at the end of singleton tags in parsed HTML output

5 participants