feat: Add document tokens from key value items #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 Require two reviewer for test updatesWonderful, this rule succeeded.When test data is updated, we require two reviewers
|
cau-git
previously approved these changes
Mar 19, 2025
Collaborator
|
I would rebase this work on top of #192 once the latter is finalized / merged, i.e. presumably by end of week. |
Collaborator
|
Hi @Saidgurbuz, #192 has been merged, you can port this work on top of the newly introduced DocTags serializer. |
Signed-off-by: Saidgurbuz <said.gurbuz@epfl.ch>
Signed-off-by: Saidgurbuz <said.gurbuz@epfl.ch>
Signed-off-by: Saidgurbuz <said.gurbuz@epfl.ch>
Signed-off-by: Saidgurbuz <said.gurbuz@epfl.ch>
Signed-off-by: Saidgurbuz <said.gurbuz@epfl.ch>
Signed-off-by: Saidgurbuz <said.gurbuz@epfl.ch>
Saidgurbuz
force-pushed
the
dev/add-document-tokens-from-kv-items
branch
from
71aa8ae to
45754b8
Compare
Signed-off-by: Saidgurbuz <said.gurbuz@epfl.ch>
vagenas
approved these changes
Mar 24, 2025
* updates for key value region Signed-off-by: Panos Vagenas <pva@zurich.ibm.com> * deprecate "new_line" parameter Signed-off-by: Panos Vagenas <pva@zurich.ibm.com> --------- Signed-off-by: Panos Vagenas <pva@zurich.ibm.com> Signed-off-by: Panos Vagenas <35837085+vagenas@users.noreply.github.com>
vagenas
force-pushed
the
dev/add-document-tokens-from-kv-items
branch
from
494d0f9 to
ad00546
Compare
vagenas
approved these changes
Mar 24, 2025
cau-git
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.