fix: fix definition issues in record type #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ceberam
commented
Jul 17, 2024
ceberam
commented
- docs: refer to Docling data objects
- fix(rec): fix definition issues in attribute, predicate, subject
- style: enforce some pre-commit hooks on tests
- fix(test): set static typing compatible to python 3.10
- docs: refer to Docling data objects
Signed-off-by: Cesar Berrospi Ramis <75900930+ceberam@users.noreply.github.com>
Enforce pre-commit hooks black, isort, autoflake, and mypy on test modules. Signed-off-by: Cesar Berrospi Ramis <75900930+ceberam@users.noreply.github.com>
Remove duplicate generic types across base and predicate modules. Create an identifier class for subject names. Remove unnecessary type variables in attribute model. Signed-off-by: Cesar Berrospi Ramis <75900930+ceberam@users.noreply.github.com>
Signed-off-by: Cesar Berrospi Ramis <75900930+ceberam@users.noreply.github.com>
vagenas
approved these changes
Jul 17, 2024
muhark
added a commit
to muhark/docling-core
that referenced
this pull request
Mar 19, 2025
* fix(test): set static typing compatible to python 3.10 Signed-off-by: Cesar Berrospi Ramis <75900930+ceberam@users.noreply.github.com> * style: enforce some pre-commit hooks on tests Enforce pre-commit hooks black, isort, autoflake, and mypy on test modules. Signed-off-by: Cesar Berrospi Ramis <75900930+ceberam@users.noreply.github.com> * fix(rec): fix definition issues in attribute, predicate, subject Remove duplicate generic types across base and predicate modules. Create an identifier class for subject names. Remove unnecessary type variables in attribute model. Signed-off-by: Cesar Berrospi Ramis <75900930+ceberam@users.noreply.github.com> * docs: refer to Docling data objects Signed-off-by: Cesar Berrospi Ramis <75900930+ceberam@users.noreply.github.com> --------- Signed-off-by: Cesar Berrospi Ramis <75900930+ceberam@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.