Make iconv install handled by DocPad itself #468

Closed
balupton opened this Issue Mar 23, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@balupton
Member

balupton commented Mar 23, 2013

NPM really really struggles with iconv it seems, as well as travis ci, and some windows locations. We need to make this only installed if the user actually needs it.

@jhuntdog

This comment has been minimized.

Show comment Hide comment
@jhuntdog

jhuntdog Mar 23, 2013

Awesome! Iconv fails on windows for me despite following all sorts of different suggestions from node-gyp (and breaking npm multiple times in the process).

Awesome! Iconv fails on windows for me despite following all sorts of different suggestions from node-gyp (and breaking npm multiple times in the process).

balupton added a commit that referenced this issue Mar 25, 2013

v6.27.0. Improvement.
- v6.27.0 March 25, 2013
	- Engine requirements are now:
		- node >=0.8
		- npm >=1.2
	- Iconv is now a lazy loaded dependency
		- Thanks to [jhuntdog](https://github.com/jhuntdog) for [issue
#468](#468)
	- Added `regenerateDelay` configuration option
		- Thanks to [Homme Zwaagstra](https://github.com/homme) for [pull
request #426](#426)
@balupton

This comment has been minimized.

Show comment Hide comment
@balupton

balupton Mar 25, 2013

Member

Landed in the just released v6.27.0 :)

Member

balupton commented Mar 25, 2013

Landed in the just released v6.27.0 :)

@balupton balupton closed this Mar 25, 2013

balupton added a commit that referenced this issue Oct 23, 2013

v6.27.0. Improvement.
- v6.27.0 March 25, 2013
	- Engine requirements are now:
		- node >=0.8
		- npm >=1.2
	- Iconv is now a lazy loaded dependency
		- Thanks to [jhuntdog](https://github.com/jhuntdog) for [issue
#468](#468)
	- Added `regenerateDelay` configuration option
		- Thanks to [Homme Zwaagstra](https://github.com/homme) for [pull
request #426](#426)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment