Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic pages after 6.57.3 #767

Closed
peterhaldbaek opened this issue Jan 10, 2014 · 14 comments
Closed

Dynamic pages after 6.57.3 #767

peterhaldbaek opened this issue Jan 10, 2014 · 14 comments

Comments

@peterhaldbaek
Copy link

@peterhaldbaek peterhaldbaek commented Jan 10, 2014

There seems to be a problem with dynamic pages since 6.57.3. When I type an incorrect URL and receive a 404 the (dynamic) error page sometimes does not show (sometimes it does) but any requests to static pages after that are shown without layout.

If I make the 404 page static everything behaves nicely. The latest version of DocPad where it works for me is 6.57.3.

You can recreate this by running the twitter-bootstrap-jade.docpad plugin and hit a non-existing URL.

Node 0.10.23.


Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

@michaelsbradleyjr
Copy link

@michaelsbradleyjr michaelsbradleyjr commented Jan 12, 2014

I'm experiencing this problem as well.

@RobLoach
Copy link
Contributor

@RobLoach RobLoach commented Jan 12, 2014

Using Clean URLs plugin?

@michaelsbradleyjr
Copy link

@michaelsbradleyjr michaelsbradleyjr commented Jan 12, 2014

I'm brand new to docpad, simply did an npm install -g ..., cloned some of the skeletons, npm install . then docpad run and began seeing the 404s and the pages being spuriously returned "without layout", as @peterhaldbaek wrote.

In other words, I'm not sure if the "Clean URLs" plugin is in play.

@michaelsbradleyjr
Copy link

@michaelsbradleyjr michaelsbradleyjr commented Jan 12, 2014

Okay, I just checked and two of the skeletons I cloned do use that plugin, and those are the two with which I experienced the problems described above.

@peterhaldbaek
Copy link
Author

@peterhaldbaek peterhaldbaek commented Jan 12, 2014

I'm using the Clean URLs plugin. I removed it and I still see unexpected behavior. If I type a non-existing URL I still get the 404 but the error page is not showing. Instead it seems to render one of my layouts (the jade template itself).

@balupton
Copy link
Member

@balupton balupton commented Jan 21, 2014

If anyone can submit a pull request for this, that would be amazing.

@greduan
Copy link
Contributor

@greduan greduan commented Jan 21, 2014

If somebody could upload a repo with everything included that would also be nice. No gitignore stuff in the middle.

@djskinner
Copy link

@djskinner djskinner commented Jan 22, 2014

I'm fairly sure that #778 and #741 are essentially the same issue...

@balupton
Copy link
Member

@balupton balupton commented Mar 4, 2014

Can confirm. This has broken the kitchensink skeleton. Needs to be fixed. Has anyone had any progress looking into this?

@balupton
Copy link
Member

@balupton balupton commented Mar 4, 2014

Seems that it could be an issue with the router, or a conflict with livereload, rather than an issue with DocPad's generation process per se.

balupton added a commit to docpad-archive/docpad-skeleton-kitchensink that referenced this issue Mar 4, 2014
Bugs are:

- docpad/docpad#767
- docpad/docpad#807

This would also be nice to have:

- docpad/docpad#402
balupton added a commit to docpad-archive/documentation that referenced this issue Mar 4, 2014
@peterhaldbaek
Copy link
Author

@peterhaldbaek peterhaldbaek commented Mar 4, 2014

No, I haven't looked further into this. I actually got the impression it was fixed in some of the later releases (6.61.0 or 6.62.0 I think) since some light testing didn't reveal the issue but I never tested it thoroughly. My memory on this could be wrong though. And since my blog is running fine on 6.57.3 I haven't had an urgent need to check up on this.

@deinhofer
Copy link

@deinhofer deinhofer commented Oct 9, 2014

I would like to use the search.html.coffee of the kitchensink skeleton in another repository. But have the same problem, it does not work any more:

When running docpad run, it announces that it would regenerate it, but if I try to open the page in the browser it redirects to the main page.

Are there any plans to fix this soon?
I am using docad 6.69.1

If it is not gonna fixed soon, is it easily possible to downgrade to 6.57.3?

@balupton
Copy link
Member

@balupton balupton commented Jul 20, 2018

Closing in favour of #1081

@balupton balupton closed this Jul 20, 2018
@michaelsbradleyjr
Copy link

@michaelsbradleyjr michaelsbradleyjr commented Jul 20, 2018

It's been so long that when I saw the email notif from GitHub just now, I was like... what's docpad? Will have to give it another look. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants