Fixed an issue with content type being looked up twice #273

Merged
merged 2 commits into from Aug 10, 2012

Conversation

Projects
None yet
2 participants
@ncrohn
Contributor

ncrohn commented Jul 21, 2012

There was a problem with the content type being set incorrectly after being looked up twice.

Initially looked up here: https://github.com/bevry/docpad/blob/master/src/lib/models/document.coffee#L363

Then looked up again from running: https://github.com/bevry/docpad/blob/master/src/lib/docpad.coffee#L2550

The contentType method provided by Express just calls mime.lookup and fails on files like JavaScript which the mime type doesn't match on application/javascript.

@balupton

This comment has been minimized.

Show comment Hide comment
@balupton

balupton Jul 23, 2012

Member

Nice find :) Will pull in the next batch :)

Member

balupton commented Jul 23, 2012

Nice find :) Will pull in the next batch :)

@balupton

This comment has been minimized.

Show comment Hide comment
@balupton

balupton Aug 10, 2012

Member

Merged into dev :) Will post back once published

Member

balupton commented Aug 10, 2012

Merged into dev :) Will post back once published

@balupton balupton merged commit a2fb5f4 into docpad:master Aug 10, 2012

@balupton

This comment has been minimized.

Show comment Hide comment
@balupton

balupton Aug 10, 2012

Member

Published to DocPad v6.5.5

Member

balupton commented Aug 10, 2012

Published to DocPad v6.5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment