Line numbering and code now vertically align. Fixes issue #5. #6

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@michaelward82

This CSS change has only been tested in Chrome and Firefox on Windows XP. I will attempt to test further, but my time is limited at the moment. I someone else could review this for browser compatibility that would be great :)

@michaelward82

This comment has been minimized.

Show comment Hide comment
@michaelward82

michaelward82 Jul 9, 2013

Having read the readme I get the feeling that I have made the changes in the wrong place.

Point me in the right direction if I have edited the wrong files.

Having read the readme I get the feeling that I have made the changes in the wrong place.

Point me in the right direction if I have edited the wrong files.

@terryweiss

This comment has been minimized.

Show comment Hide comment
@terryweiss

terryweiss Jul 9, 2013

Collaborator

Dude! Thanks for helping out!

You are right, those changes will be overwritten. In the root directory, styles/main.less includes all of the docstrap specific styles. They are included after the other styles and so you should not have to battle anything with !important, but in this case since you deleted out a bunch of <pre/> styling you may have to style <pre/> by first resetting it. Just run grunt less to build and test the css.

Again, thanks for the help!
t.

Collaborator

terryweiss commented Jul 9, 2013

Dude! Thanks for helping out!

You are right, those changes will be overwritten. In the root directory, styles/main.less includes all of the docstrap specific styles. They are included after the other styles and so you should not have to battle anything with !important, but in this case since you deleted out a bunch of <pre/> styling you may have to style <pre/> by first resetting it. Just run grunt less to build and test the css.

Again, thanks for the help!
t.

@michaelward82

This comment has been minimized.

Show comment Hide comment
@michaelward82

michaelward82 Jul 10, 2013

No problem - I'll take a look at making the changes properly when I get a little time.

No problem - I'll take a look at making the changes properly when I get a little time.

marklagendijk pushed a commit to marklagendijk/docstrap that referenced this pull request Nov 11, 2013

@terryweiss terryweiss closed this Dec 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment