From 63ca45b49e19a9f741132b3973c24941ab69b1ff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Paris?= Date: Thu, 14 Mar 2024 23:26:12 +0100 Subject: [PATCH 1/4] Document actual key type --- Middleware/BacktraceDebugDataHolder.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Middleware/BacktraceDebugDataHolder.php b/Middleware/BacktraceDebugDataHolder.php index 7d679ca71..8eae91188 100644 --- a/Middleware/BacktraceDebugDataHolder.php +++ b/Middleware/BacktraceDebugDataHolder.php @@ -17,7 +17,7 @@ class BacktraceDebugDataHolder extends DebugDataHolder /** @var string[] */ private array $connWithBacktraces; - /** @var array[]> */ + /** @var array[]> */ private array $backtraces = []; /** @param string[] $connWithBacktraces */ From 6afc428221d348639648a7b89c44bd7027069e23 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Paris?= Date: Thu, 14 Mar 2024 23:26:51 +0100 Subject: [PATCH 2/4] Add missing dependency We use it in one of our classes, that we should be able to statically analyze or test. --- composer.json | 1 + 1 file changed, 1 insertion(+) diff --git a/composer.json b/composer.json index 38692af10..f3525bdb6 100644 --- a/composer.json +++ b/composer.json @@ -58,6 +58,7 @@ "symfony/property-info": "^5.4 || ^6.0 || ^7.0", "symfony/proxy-manager-bridge": "^5.4 || ^6.0 || ^7.0", "symfony/security-bundle": "^5.4 || ^6.0 || ^7.0", + "symfony/stopwatch": "^5.4 || ^6.0 || ^7.0", "symfony/string": "^5.4 || ^6.0 || ^7.0", "symfony/twig-bridge": "^5.4 || ^6.0 || ^7.0", "symfony/validator": "^5.4 || ^6.0 || ^7.0", From aa93d75058d6c06ae97a1b9e1f29bb3a46bba6a1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Paris?= Date: Thu, 14 Mar 2024 23:27:21 +0100 Subject: [PATCH 3/4] Ignore issues about calling internal class from the Doctrine bridge --- Middleware/DebugMiddleware.php | 1 + 1 file changed, 1 insertion(+) diff --git a/Middleware/DebugMiddleware.php b/Middleware/DebugMiddleware.php index d8e4b68fc..55aaabb54 100644 --- a/Middleware/DebugMiddleware.php +++ b/Middleware/DebugMiddleware.php @@ -27,6 +27,7 @@ public function setConnectionName(string $name): void public function wrap(DriverInterface $driver): DriverInterface { + /** @psalm-suppress InternalClass,InternalMethod */ return new Driver($driver, $this->debugDataHolder, $this->stopwatch, $this->connectionName); } } From d05c094e62da781354261b590d8633153debfc8d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Paris?= Date: Thu, 14 Mar 2024 23:18:53 +0100 Subject: [PATCH 4/4] Analyze Middleware directory It seems to have been forgotten. --- psalm.xml.dist | 1 + 1 file changed, 1 insertion(+) diff --git a/psalm.xml.dist b/psalm.xml.dist index 5937bae63..d8ad87b5b 100644 --- a/psalm.xml.dist +++ b/psalm.xml.dist @@ -28,6 +28,7 @@ +