Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore deprecation for RegistryInterface #1000

Merged
merged 1 commit into from Aug 4, 2019

Conversation

@alcaeus
Copy link
Member

commented Aug 4, 2019

We can't remove usage of that interface without breaking BC, so the tests running against Symfony 4.4 will have to ignore that single deprecation. The interface will be dropped from the class declaration for 2.0, along with the deprecated methods.

@alcaeus alcaeus added the Improvement label Aug 4, 2019

@alcaeus alcaeus added this to the 1.12.0 milestone Aug 4, 2019

@alcaeus alcaeus self-assigned this Aug 4, 2019

@alcaeus alcaeus force-pushed the alcaeus:ignore-sf-4.4-deprecation branch from b8a2dfe to c0c4313 Aug 4, 2019

@alcaeus alcaeus added this to 1.12 in Roadmap Aug 4, 2019

@alcaeus alcaeus merged commit 88e5ac9 into doctrine:1.12.x Aug 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alcaeus alcaeus deleted the alcaeus:ignore-sf-4.4-deprecation branch Aug 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.