Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require php-7.4-friendly version of Twig #1025

Merged
merged 2 commits into from Oct 8, 2019

Conversation

@greg0ire
Copy link
Member

commented Oct 6, 2019

@greg0ire greg0ire referenced this pull request Oct 6, 2019
@fabpot
fabpot approved these changes Oct 6, 2019
@greg0ire

This comment has been minimized.

Copy link
Member Author

commented Oct 6, 2019

The build fails because of a new deprecation in sf 4.4 . I'm adding a second commit that should fix it.

@greg0ire greg0ire requested a review from doctrine/team-symfony-integration Oct 6, 2019
@fabpot
fabpot approved these changes Oct 7, 2019
@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Oct 7, 2019

could be inside the try?
GenerateEntitiesDoctrineCommand also needs it, isn't it?

This is mandatory since Symfony 4.4
@greg0ire greg0ire force-pushed the greg0ire:ensure-compatibility-with-7.4 branch from 70ed682 to 741ac22 Oct 7, 2019
@greg0ire

This comment has been minimized.

Copy link
Member Author

commented Oct 7, 2019

@nicolas-grekas done and done :)

composer.json Show resolved Hide resolved
@alcaeus
alcaeus approved these changes Oct 8, 2019
@alcaeus

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

Thanks @greg0ire!

@alcaeus alcaeus merged commit 4def364 into doctrine:1.12.x Oct 8, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alcaeus alcaeus added the Improvement label Oct 8, 2019
@alcaeus alcaeus added this to the 1.12.0 milestone Oct 8, 2019
@alcaeus alcaeus added this to 1.12 in Roadmap Oct 8, 2019
@greg0ire greg0ire deleted the greg0ire:ensure-compatibility-with-7.4 branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5 participants
You can’t perform that action at this time.