Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Correct the require string for jdorn/sql-formatter #136

Merged
merged 1 commit into from Nov 16, 2012

Conversation

Projects
None yet
5 participants
Contributor

lucasaba commented Nov 16, 2012

I'm not sure about this but, as I was trying to install Symfony bundle
with composer I had this error:
Problem 1
    - Installation request for doctrine/doctrine-bundle dev-master -> satisfiable by doctrine/doctrine-bundle dev-master.
    - doctrine/doctrine-bundle dev-master requires jdorn/sql-formatter 1.0.1 -> no matching package

If I've understood how packgist and composer work, the corret
require line should be the corrected one.
Or at least, should be this:
"jdorn/sql-formatter": "1.0.x-dev"

Correct the require string for jdorn/sql-formatter
I'm not sure about this but, as I was trying to install Symfony bundle
with composer I had this error:
Problem 1
    - Installation request for doctrine/doctrine-bundle dev-master -> satisfiable by doctrine/doctrine-bundle dev-master.
    - doctrine/doctrine-bundle dev-master requires jdorn/sql-formatter 1.0.1 -> no matching package

If I've understood how packgist and composer work, the corret 
require line should be the corrected one.
Or at least, should be this:
"jdorn/sql-formatter": "1.0.x-dev"

@lucasaba lucasaba referenced this pull request in symfony/symfony-standard Nov 16, 2012

Closed

Unable to install dev-master #444

Member

fabpot commented Nov 16, 2012

👍

asm89 added a commit that referenced this pull request Nov 16, 2012

Merge pull request #136 from lucasaba/patch-1
Correct the require string for jdorn/sql-formatter

@asm89 asm89 merged commit 47df202 into doctrine:master Nov 16, 2012

1 check passed

default The Travis build passed
Details

@lucasaba lucasaba referenced this pull request in symfony/symfony-standard Nov 16, 2012

Closed

Update composer.lock to a new DoctrinBundle commit #445

Member

stof commented Nov 17, 2012

@Seldaek why would we need to use the pretty version here ? It does not make any sense.

Member

Seldaek commented Nov 17, 2012

That does not make sense indeed. Those should be equivalent.

Contributor

lucasaba commented Nov 17, 2012

I made the change because I'm not sure of how composer/packagist work.
Everything is connected to this: symfony/symfony-standard#444
I thought that since composer issue this error:

  • doctrine/doctrine-bundle 1.0.x-dev requires jdorn/sql-formatter 1.0.1 -> no matching package found.

updating the reference with the pretty version would have solved the issue. But I've realized that the problem perists.
I've made a symfony standard package with all the changes and now the error is:

  • doctrine/doctrine-bundle 1.0.x-dev requires jdorn/sql-formatter v1.0.1 -> no matching package found.
Member

Seldaek commented Nov 17, 2012

Sent a proper fix for that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment