Fix build #1475
Merged
Fix build #1475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently it was added in a08bc3b to satisfy Psalm. Either there was an issue with that version of Psalm or more helpful phpdoc was added to upstream packages, which makes this code block redundant.
This class implements an interface that requires getClassName() to return a class-string.
Attributes are available since PHP 8.
greg0ire
force-pushed
the
fix-build
branch
3 times, most recently
from
e949545 to
1614140
Compare
This option was overlooked when migrating to reusable workflows.
greg0ire
requested review from
SenseException,
beberlei,
derrabus and
ostrolucky
derrabus
approved these changes
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted while working on #1471
I see that @ostrolucky already fixed some issues this morning 🙂 , here is another batch of fixes.