Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

removed the need for a routing file in the profiler #150

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Member

fabpot commented Jan 11, 2013

This PR simplifies the code for the profiler: having to register a route for a panel in the profiler is not really great. This is the only possibility in 2.0 and 2.1, but for 2.2, we can do better.

Be careful though as this PR cannot be merged as is in master as the code is only for Symfony 2.2.0+. I think we need to create a 2.1 branch first for the code compatible with Symfony 2.1, so that master can get some improvements that need 2.2.

See symfony/symfony-standard#470 for the original report (wich should be fixed in Symfony SE but only for 2.0 and 2.1).

What do you think?

@fabpot fabpot referenced this pull request in symfony/symfony-standard Jan 11, 2013

Closed

[DoctrineBundle] internal ajax routes are not loaded #470

Member

stof commented Jan 11, 2013

for 2.1, couldn't we switch back to the controller notation ? AFAIK, it still work in it. The need of a route was added only for Sf 2.2-beta1. But this would make the bundle incompatible with beta1 too, right ?

I will handle do the branching this evening.

Member

stof commented Jan 12, 2013

@fabpot how could we handle 2.2.0-beta1 ? I would like to revert #142 in the branch targetting Symfony 2.1, to revert the BC break needing the routing file, and to use your new code for 2.2-beta2+. But 2.2-beta1 does not have a way to use a controller reference

stof added a commit that referenced this pull request Jan 12, 2013

Member

stof commented Jan 12, 2013

Here it is.

The 1.1.x branch contains the bundle for 2.1, and 1.1.0 is released (the 2.1 branch of the SE should be updated to 1.1 instead of shipping with 1.0.* btw). And #142 has been reverted to avoid requiring a routing file for 2.1 users.

the master branch (aliased as 1.2.x-dev) is for Symfony 2.2.0beta2+, by merging this PR (rebased).

for Symfony 2.2.0-beta1, there is no way to make the bundle work without BC break, and the SE was released without the update for #142 anyway. I kept a branch temporarily with the code shipped in the beta1 release but I'm not sure running a composer update will be able to find it because of the 1.0.* requirement in beta1. So my suggestion would be to have the beta2 as soon as possible.

I will sned PRs to the SE to update the requirements.

@stof stof closed this Jan 12, 2013

@jrobeson jrobeson referenced this pull request in doctrine/DoctrineFixturesBundle Jan 12, 2013

Closed

incompatible with symfony 2.2 due to requirement of doctrine-bundle.1.0.* #72

@fabpot fabpot deleted the fabpot:profiler-fix branch Jan 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment