Enabling filter's default parameters in config files #159
Conversation
ManagerConfigurator.php
Outdated
There was a problem hiding this comment.
$filter is the filter name and $oFilter the filter object, is it a problem?
There was a problem hiding this comment.
we are not using the o*, s* convention to name variable starting with their type. So it is weird to have it used in a single place.
There was a problem hiding this comment.
ok, $filterObject sounds better?
|
your XML configuration will not work(try to put at lest 2 parameters) as it is not how prototype nodes should be represented. |
ManagerConfigurator.php
Outdated
|
This will fix previouly said bad things |
ManagerConfigurator.php
Outdated
There was a problem hiding this comment.
spaces should be around the braces, not inside them
ManagerConfigurator.php
Outdated
|
+1 -- I need this functionality as well (ability to set parameters for filters within config). |
|
👍 we need this PR at work |
Enabling filter's default parameters in config files
|
Is there a way to use the service container to inject a value? Eg, I have a Site Context and I want to use the SiteId from that Entity. May relate to #134 |
5 participants
Hi stof,
This update is comming from troubles we had to set a filter parameter at the application start, it enable default values in the config files without breaking older configs.
Jérémy