Added a button to expand all queries #173

Merged
merged 1 commit into from Jun 16, 2013

Conversation

Projects
None yet
3 participants
Contributor

XWB commented Mar 24, 2013

The easiest way to find a specific SQL string on a page with 100+ queries is to expand them all and hit CTRL + F.

Member

stof commented Mar 25, 2013

Your button does not behave like an expandAll. It is a toggleAll. If some of the queries are already expanded, clicking on expandAll will collapse them with your implementation

Contributor

XWB commented Mar 26, 2013

You are right. I'm however fine with the toggle behavior so I've changed the function name.

Member

stof commented Mar 26, 2013

The button toggling from a + image to a - is weird as it is a toggle, meaning that if you expand all queries individually first, you end up with + collapsing and - expanding.

Contributor

XWB commented Mar 26, 2013

How about a default button?

<button type="button" class="sf-button">
    <span class="border-l">
        <span class="border-r">
            <span class="btn-bg">Toggle</span>
        </span>
    </span>
</button>
Contributor

XWB commented Mar 29, 2013

@stof It is now a real button.

Contributor

XWB commented Apr 10, 2013

Ping @stof

Resources/views/Collector/db.html.twig
@@ -62,11 +62,21 @@
<em>No queries.</em>
</p>
{% else %}
+ <br>
@stof

stof Apr 11, 2013

Member

you should remove this <br> tag IMO

@XWB

XWB Apr 12, 2013

Contributor

@stof A little preview.

With <br> tag:

button-2

And without:

button-1

Member

asm89 commented Apr 12, 2013

@stof @XWB Why don't we evolve this in an "expand all" button instead? This toggle thing feels like a bit of a hack imo.

Contributor

XWB commented May 16, 2013

It's now a "real" expand button.

ping @stof

Contributor

XWB commented Jun 4, 2013

@stof ping

stof added a commit that referenced this pull request Jun 16, 2013

Merge pull request #173 from XWB/expand-all-queries
Added a button to expand all queries

@stof stof merged commit 5a4d572 into doctrine:master Jun 16, 2013

1 check passed

default The Travis CI build passed
Details
Contributor

XWB commented Jun 16, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment