[WIP] Second-level cache configuration #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Dec 28, 2013
…re not an EM's child (FabioBatSilva) This PR was merged into the 2.5-dev branch. Discussion ---------- [Bridge] [DoctrineExtension] Allow cache drivers that are not an EM's child | Q | A | ------------- | --- | Bug fix? | [no] | New feature? | [yes] | BC breaks? | [no] | Deprecations? | [no] | Tests pass? | [yes|] | Fixed tickets | [] | License | MIT | Doc PR | [doctrine/orm#808, doctrine/DoctrineBundle#224] Commits ------- 7528e4c Allow cache drivers that are not an EM's child
fabpot
added a commit
to symfony/doctrine-bridge
that referenced
this pull request
Dec 28, 2013
…re not an EM's child (FabioBatSilva) This PR was merged into the 2.5-dev branch. Discussion ---------- [Bridge] [DoctrineExtension] Allow cache drivers that are not an EM's child | Q | A | ------------- | --- | Bug fix? | [no] | New feature? | [yes] | BC breaks? | [no] | Deprecations? | [no] | Tests pass? | [yes|] | Fixed tickets | [] | License | MIT | Doc PR | [doctrine/orm#808, doctrine/DoctrineBundle#224] Commits ------- 7528e4c Allow cache drivers that are not an EM's child
|
Ping @doctrine/team-doctrine2, @stof |
| * @author Fabien Potencier <fabien@symfony.com> | ||
| * @author Fabio B. Silva <fabio.bat.silva@gmail.com> | ||
| */ | ||
| class CollectionRegionDoctrineCommand extends CollectionRegionCommand |
There was a problem hiding this comment.
Picky: shouldn't this rather be named ClearCollectionRegionDoctrineCommand? This is more convenient IMO.
There was a problem hiding this comment.
Got this error after trying to do an update with composer:
/vendor/doctrine/doctrine-bundle/Doctrine/Bundle/DoctrineBundle/Command/Proxy/CollectionRegionDoctrineCommand.php on line 29
Any thoughts?
Merged
|
Merged as of #247 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch add support for second-level cache doctrine/orm#808
Please notice that changes made in
DoctrineExtension#loadCacheDrivershould be moved to Symfony Bridge once we finish the work here...Cheers