New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default command name to DI config #127

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@johmanx10

johmanx10 commented Dec 1, 2017

Closes #126

This solves compilation errors in Symfony >= 3.4

@fabpot Consequently I have issues with this default command name in all my bundles that register commands using tags. Is there something I'm doing incorrectly here?

@alcaeus

This comment has been minimized.

Show comment
Hide comment
@alcaeus

alcaeus Dec 1, 2017

Member

Something is fishy. Yes, this fixes the error, but if you ask me this is a BC break introduced in symfony/symfony#23887. @fabpot @nicolas-grekas what do you think?

I stand corrected - looks like this error was introduced in #120.

Member

alcaeus commented Dec 1, 2017

Something is fishy. Yes, this fixes the error, but if you ask me this is a BC break introduced in symfony/symfony#23887. @fabpot @nicolas-grekas what do you think?

I stand corrected - looks like this error was introduced in #120.

@johmanx10

This comment has been minimized.

Show comment
Hide comment
@johmanx10

johmanx10 Dec 1, 2017

This pull request will be closed because the corresponding issue is deemed invalid.

johmanx10 commented Dec 1, 2017

This pull request will be closed because the corresponding issue is deemed invalid.

@johmanx10 johmanx10 closed this Dec 1, 2017

@johmanx10 johmanx10 deleted the mediact:hotfix/AEQ-286 branch Dec 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment