Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fixture load paths to be configured in the bundle configuration #139

Closed
wants to merge 1 commit into from

Conversation

tystr
Copy link

@tystr tystr commented Apr 14, 2015

This PR adds the ability to configure an array of paths from which fixtures will be loaded.

(This was suggested in #102).

@tystr tystr changed the title Allow fixture paths to be configured in the bundle configuration Allow fixture load paths to be configured in the bundle configuration Apr 14, 2015
@bbbshah
Copy link

bbbshah commented May 21, 2015

👍

@stefanbauer
Copy link

Big +1

@jdecool
Copy link

jdecool commented Mar 21, 2016

No new about this PR ?

@weaverryan
Copy link
Contributor

👍 to me - this looks well-done and well-tested.

@tystr Perhaps you could add a small config section at the bottom of the docs: https://github.com/doctrine/DoctrineFixturesBundle/blob/master/Resources/doc/index.rst

use Symfony\Component\Config\Definition\Builder\NodeDefinition;

/**
* @author Tyler Stroud <tyler@tylerstroud.com>:e
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo at the end of this line: :e

@tystr tystr force-pushed the configurable-fixture-paths branch from c5dbcbf to fdd0dbc Compare April 22, 2016 16:57
@tystr
Copy link
Author

tystr commented Apr 22, 2016

@weaverryan Added an optional step 3 under the "Setup and Configuration" section and adjusted some wording.
Also made the changes @javiereguiluz requested.

@weaverryan
Copy link
Contributor

Thanks for the fast changes @tystr!

👍 Looks ready to merge

@tystr tystr force-pushed the configurable-fixture-paths branch from fdd0dbc to 71eae76 Compare April 25, 2016 16:49
@honzagula
Copy link

I guess this will be required for bundle-less Symfony 4 structure

@nickell-flosports
Copy link

👍

@gregurco
Copy link

👍

2 similar comments
@mtamazlicaru
Copy link

👍

@Viorrika
Copy link

👍

@doctrine doctrine locked and limited conversation to collaborators Sep 19, 2017
@alcaeus
Copy link
Member

alcaeus commented Sep 19, 2017

Locking conversation to maintainers to prevent against 👍 comments.

@weaverryan @javiereguiluz is there anything else that needs to be done here?

@alcaeus
Copy link
Member

alcaeus commented Nov 28, 2017

With #209, this is no longer relevant: closing here.

@alcaeus alcaeus closed this Nov 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet