New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow fixture load paths to be configured in the bundle configuration #139
Conversation
👍 |
Big +1 |
No new about this PR ? |
👍 to me - this looks well-done and well-tested. @tystr Perhaps you could add a small config section at the bottom of the docs: https://github.com/doctrine/DoctrineFixturesBundle/blob/master/Resources/doc/index.rst |
use Symfony\Component\Config\Definition\Builder\NodeDefinition; | ||
|
||
/** | ||
* @author Tyler Stroud <tyler@tylerstroud.com>:e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo at the end of this line: :e
c5dbcbf
to
fdd0dbc
Compare
@weaverryan Added an optional step 3 under the "Setup and Configuration" section and adjusted some wording. |
Thanks for the fast changes @tystr! 👍 Looks ready to merge |
fdd0dbc
to
71eae76
Compare
I guess this will be required for bundle-less Symfony 4 structure |
👍 |
👍 |
2 similar comments
👍 |
👍 |
Locking conversation to maintainers to prevent against 👍 comments. @weaverryan @javiereguiluz is there anything else that needs to be done here? |
With #209, this is no longer relevant: closing here. |
This PR adds the ability to configure an array of paths from which fixtures will be loaded.
(This was suggested in #102).