Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The parameter "doctrine_migrations.dir_name" has a dependency on a non-existent parameter "kernel.root_dir" #305

Closed
emodric opened this issue Mar 24, 2020 · 5 comments

Comments

@emodric
Copy link

@emodric emodric commented Mar 24, 2020

When using Doctrine Migrations Bundle 2.1 on Symfony 5 with default config, the above error message is emmited due to DI configuration class using kernel.root_dir parameter to build a default value for root_dir param.

@alcaeus

This comment has been minimized.

Copy link
Member

@alcaeus alcaeus commented Mar 27, 2020

See #295 for a previous attempt at fixing this and related discussion.

@emodric

This comment has been minimized.

Copy link
Author

@emodric emodric commented Mar 27, 2020

Whoops, sorry for the new issue, tried to search through issues with root_dir and failed :)

Should I close this?

@emodric

This comment has been minimized.

Copy link
Author

@emodric emodric commented Mar 27, 2020

So the consensus is just make sure that the parameter is configured, right?

@xabbuh

This comment has been minimized.

Copy link
Member

@xabbuh xabbuh commented Mar 27, 2020

As I stated in #295 (comment) I think a forward-compatible upgrade path could be this:

I think the only safe upgrade path is to deprecate not configuring this option and making it a mandatory one in the next major release.

@emodric

This comment has been minimized.

Copy link
Author

@emodric emodric commented Mar 27, 2020

Thanks @xabbuh !

Will close this one!

@emodric emodric closed this Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.