Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

added consistency to the documentation with --show-version showing the r... #17

Merged
merged 1 commit into from

2 participants

@cordoval

...ight output with versions displaying and migrating to specific version using the data format argument

@cordoval cordoval added consistency to the documentation with --show-version showing th…
…e right output with versions displaying and migrating to specific version using the data format argument
9f513fd
@odino
Collaborator

hey @cordoval is this still on?

@cordoval

@odino could you please elaborate?

@odino
Collaborator

Im asking if the issue is still there :)

@odino odino commented on the diff
Resources/doc/index.rst
@@ -158,7 +158,7 @@ finally migrate when you're ready:
.. code-block:: bash
- php app/console doctrine:migrations:migrate
+ php app/console doctrine:migrations:migrate 20100621140655
@odino Collaborator
odino added a note

the problem here is that people would get a hint of executing each migration one by one, whereas the recommended way is (my guess) to just run doctrine:migrations:migrate

What do you think?

oh i see they made you maintainer of the bundle, never knew.

No, I disagree. The thing here is preparing ground work for what is below the up and downs. I think most people will know about migrate but not the other so it actually encourage good practice. To be careful.

@odino Collaborator
odino added a note

I see doctrine:migrations:migrate is also mentioned elsewhere, so I guess this can be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@odino odino merged commit 62e20bb into doctrine:master
@cordoval cordoval deleted the cordoval:patch-1 branch
@cordoval

i feel relieved after 2 years. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 5, 2012
  1. @cordoval

    added consistency to the documentation with --show-version showing th…

    cordoval authored
    …e right output with versions displaying and migrating to specific version using the data format argument
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 Resources/doc/index.rst
View
4 Resources/doc/index.rst
@@ -134,7 +134,7 @@ migration to execute:
.. code-block:: bash
- php app/console doctrine:migrations:status
+ php app/console doctrine:migrations:status --show-versions
== Configuration
@@ -158,7 +158,7 @@ finally migrate when you're ready:
.. code-block:: bash
- php app/console doctrine:migrations:migrate
+ php app/console doctrine:migrations:migrate 20100621140655
@odino Collaborator
odino added a note

the problem here is that people would get a hint of executing each migration one by one, whereas the recommended way is (my guess) to just run doctrine:migrations:migrate

What do you think?

oh i see they made you maintainer of the bundle, never knew.

No, I disagree. The thing here is preparing ground work for what is below the up and downs. I think most people will know about migrate but not the other so it actually encourage good practice. To be careful.

@odino Collaborator
odino added a note

I see doctrine:migrations:migrate is also mentioned elsewhere, so I guess this can be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
For more information on how to write the migrations themselves (i.e. how to
fill in the ``up()`` and ``down()`` methods), see the official Doctrine Migrations
Something went wrong with that request. Please try again.