Filter config support #170

Merged
merged 5 commits into from Feb 11, 2013

Projects

None yet

4 participants

@WesleyVanOpdorp

Ported the doctrine orm bundle filter configuration / setup to mongo db odm. The addFilter implementation was already there but the configuration wasn't red or used.

@jwage
Doctrine member

Looks like tests need some updating.

@WesleyVanOpdorp

I will update this request once I've fixed the tests, and added some new ones.

@stof
Doctrine member

Please revert the permission change

@WesleyVanOpdorp

I have updated the tests and reverted the file permission change.

@WesleyVanOpdorp

Could anyone please review my request? Thanks.

@jmikola
Doctrine member

It looks like permissions for all existing files are still being changed to 755:

  • DependencyInjection/Configuration.php
  • DependencyInjection/DoctrineMongoDBExtension.php
  • Resources/config/mongodb.xml
  • Tests/DependencyInjection/ConfigurationTest.php
  • Tests/DependencyInjection/Fixtures/config/yml/full.yml
@WesleyVanOpdorp

Can someone please merge this?

@jmikola
Doctrine member

Sorry for the delay. Tests look good.

@jmikola jmikola merged commit ae16f64 into doctrine:master Feb 11, 2013
@jmikola
Doctrine member

Would you be willing to add a documentation snippet for this in a separate PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment