add support for limit() and skip() #172

Merged
merged 1 commit into from Jan 29, 2013

Conversation

Projects
None yet
2 participants
Contributor

scourgen commented Jan 28, 2013

see #171

Owner

jmikola commented Jan 29, 2013

One question: does this lead to limit(0) always being appended to the query log? IIRC, the limit defaults to 0 and might always be set.

Contributor

scourgen commented Jan 29, 2013

I did some test, When I don't set the limit manually(such like use findAll(),findById(),etc ), there's no $log['limit'] anyway.So It won't be a problem.

jmikola added a commit that referenced this pull request Jan 29, 2013

Merge pull request #172 from scourgen/master
add support for limit() and skip()

@jmikola jmikola merged commit c711aa0 into doctrine:master Jan 29, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment