Doctrine namespace

[kriswallsmith]

I've moved the bundle into the Doctrine namespace.

[jmikola]

Should this not also be done for the 2.0 branch?

[kriswallsmith]

I don't think so; that would be a BC break.

[stof]

to be consistent with the fixtures and migrations bundles, it should be Doctrine\Bundle\MongoDBBundle as namespace (avoiding to duplicate Doctrine). The bundle name would still be DoctrineMongoDBBundle with such a namespace by simply applying the naming convention

[jmikola]

Ah, good catch.

[stof]

@kriswallsmith @jmikola when is it planned to merge the namespace change ?

I would like to submit PRs to use symfony/symfony#2923 (to provide mongodb: as a provider in the security config) and symfony/symfony#2921 (to remove code duplication regarding forms, making #59 obsolete too).
Either I wait for the namespace change, either I submit them using the Symfony namespace which would then require a rebase to change the namespace in the new classes.

[kriswallsmith]

I need to make some fixes but don’t have time right now. Would you like to take over this patch?

On Monday, December 19, 2011 at 9:54 AM, Christophe Coevoet wrote:

@kriswallsmith @jmikola when is it planned to merge the namespace change ?

I would like to submit PRs to use symfony/symfony#2923 (to provide mongodb: as a provider in the security config) and symfony/symfony#2921 (to remove code duplication regarding forms, making #59 obsolete too).
Either I wait for the namespace change, either I submit them using the Symfony namespace which would then require a rebase to change the namespace in the new classes.

---

Reply to this email directly or view it on GitHub:
#64 (comment)