enable quoteStrategy-Configuration #268

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
@Blaimi

Blaimi commented Sep 26, 2013

because doctrine/doctrine2#800 will not happen …

@bakura10

This comment has been minimized.

Show comment
Hide comment
@bakura10

bakura10 Sep 26, 2013

Member

I will let @Ocramius decide if you integrate this feature, but please handle the case where the quote strategy is a string so that you can fetch it from service locator (see how it's done for Naming strategy: https://github.com/doctrine/DoctrineORMModule/blob/master/src/DoctrineORMModule/Service/ConfigurationFactory.php#L66)

Member

bakura10 commented Sep 26, 2013

I will let @Ocramius decide if you integrate this feature, but please handle the case where the quote strategy is a string so that you can fetch it from service locator (see how it's done for Naming strategy: https://github.com/doctrine/DoctrineORMModule/blob/master/src/DoctrineORMModule/Service/ConfigurationFactory.php#L66)

@Ocramius

This comment has been minimized.

Show comment
Hide comment
@Ocramius

Ocramius Oct 7, 2013

Member

This PR needs a rebase

Member

Ocramius commented Oct 7, 2013

This PR needs a rebase

+ throw new InvalidArgumentException(sprintf('Quote strategy "%s" not found', $quoteStrategy));
+ }
+
+ $config->setQuoteStrategy($serviceLocator->get($quoteStrategy));

This comment has been minimized.

@Ocramius

Ocramius Oct 7, 2013

Member

Probably too picky here, but you should also check what has been fetched and throw an exception if it wasn't what you were looking for.

@Ocramius

Ocramius Oct 7, 2013

Member

Probably too picky here, but you should also check what has been fetched and throw an exception if it wasn't what you were looking for.

This comment has been minimized.

@Blaimi

Blaimi Oct 8, 2013

This code is adapted from the NamingStrategy a few lines above. If we change the code here, should we change it there too?

@Blaimi

Blaimi Oct 8, 2013

This code is adapted from the NamingStrategy a few lines above. If we change the code here, should we change it there too?

@Ocramius

This comment has been minimized.

Show comment
Hide comment
@Ocramius

Ocramius Oct 7, 2013

Member

Also: missing tests

Member

Ocramius commented Oct 7, 2013

Also: missing tests

@Blaimi Blaimi closed this Feb 3, 2015

@Blaimi

This comment has been minimized.

Show comment
Hide comment
@Blaimi

Blaimi Apr 28, 2016

This is a duplicate of #453

Blaimi commented Apr 28, 2016

This is a duplicate of #453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment