New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move supports to doctrine\migrations in another module #401
Conversation
Move doctrine\migrations supports in another module
docs/migrations.md need to be moved too? |
composer.json need to be updated to require doctrinemigrationmodule imo |
oh yes this PR has a lot of problem.. :D it's here for feedback about the idea :).. I don't know if it's needed to add doctrine-migrations-module how required.. In my opinion split it in two module is a good method to economize one dependency :P If you use migrations add DoctrineMigrationsModule if you don't use it no But thanks for this check!! :) I update my PR! |
👍 I often use doctrine/dbal + migrations, but find myself in the situation to install and configure the complete ORM to only get doctrine/migrations support in ZF2. Splitting it into a separate repo would be great. |
@codeliner would you help us? :) Try gianarb/DoctrineMigrationsModule please! :) |
@gianarb ah great. I will try it. When it is working I will add it to my new cqrs sample app: https://github.com/prooph/proophessor-do :-) |
Thanks I expect your feedback! :) 👍 |
👍 |
@gianarb I have tried https://github.com/gianarb/DoctrineMigrationsModule by requiring that :
and got error :
|
oh, seems i need minimum-stability... |
@gianarb it seems https://github.com/gianarb/DoctrineMigrationsModule is not composer-able to install yet... |
In this moment doctrineMigrations has not tag.. In this moment this feature is freezed because I wait feedback about this issue :) gianarb/DoctrineMigrationsModule#2 |
I will try git clone, wait a minute |
@gianarb i re-tried and got error :
it seems my dependency just not uptodate. I'm basically +1 for it. |
@samsonasik What do you think about the issues mentioned in gianarb/DoctrineMigrationsModule#2? |
DoctrineORMModule will maintain doctrine\migrations.. :) Thanks |
Move doctrine\migrations supports in another module
I spoke with @Ocramius and I'm here to propose this solution.
First because
doctrine2
anddoctrine\migrations
are two different projects and in my opinion is a bad idea merge them in one project.In my opinion splitting this could increase mantainability costs but will give us a better way to manage such modules.
I submit now this proposal because this increases module's stability.. WIP for 1.0.0 :)
Here new DoctrineMigrationsModule proposal