Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move supports to doctrine\migrations in another module #401

Closed
wants to merge 3 commits into from
Closed

Move supports to doctrine\migrations in another module #401

wants to merge 3 commits into from

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Apr 28, 2015

Move doctrine\migrations supports in another module

I spoke with @Ocramius and I'm here to propose this solution.
First because doctrine2 and doctrine\migrations are two different projects and in my opinion is a bad idea merge them in one project.

In my opinion splitting this could increase mantainability costs but will give us a better way to manage such modules.

I submit now this proposal because this increases module's stability.. WIP for 1.0.0 :)

Here new DoctrineMigrationsModule proposal

Move doctrine\migrations supports in another module
@gianarb gianarb added the Enhacement New feature or request label Apr 28, 2015
@gianarb gianarb added this to the 1.0.0 milestone Apr 28, 2015
@gianarb gianarb changed the title Remove supports to doctrine\migrations in another module Move supports to doctrine\migrations in another module Apr 28, 2015
@samsonasik
Copy link
Contributor

docs/migrations.md need to be moved too?

@samsonasik
Copy link
Contributor

composer.json need to be updated to require doctrinemigrationmodule imo

@gianarb
Copy link
Contributor Author

gianarb commented Apr 28, 2015

oh yes this PR has a lot of problem.. :D it's here for feedback about the idea :)..

I don't know if it's needed to add doctrine-migrations-module how required.. In my opinion split it in two module is a good method to economize one dependency :P If you use migrations add DoctrineMigrationsModule if you don't use it no

But thanks for this check!! :) I update my PR!
@samsonasik if you use migrations can you try doctrine-module-migrations?
Thanks

@codeliner
Copy link

👍 I often use doctrine/dbal + migrations, but find myself in the situation to install and configure the complete ORM to only get doctrine/migrations support in ZF2. Splitting it into a separate repo would be great.

@gianarb
Copy link
Contributor Author

gianarb commented May 5, 2015

@codeliner would you help us? :) Try gianarb/DoctrineMigrationsModule please! :)
Thanks!

@codeliner
Copy link

@gianarb ah great. I will try it. When it is working I will add it to my new cqrs sample app: https://github.com/prooph/proophessor-do :-)

@gianarb
Copy link
Contributor Author

gianarb commented May 5, 2015

Thanks I expect your feedback! :) 👍

@zluiten
Copy link
Contributor

zluiten commented May 6, 2015

👍

@samsonasik
Copy link
Contributor

@gianarb I have tried https://github.com/gianarb/DoctrineMigrationsModule by requiring that :

     "doctrine/doctrine-orm-module": "0.9.*",
        "doctrine/doctrine-migrations-module": "dev-master"

and got error :

$ composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - The requested package doctrine/doctrine-migrations-module could not be found in any version, there may be a typo in the package name.
  Problem 2
    - Installation request for sitrunlab/learnzf2 0.2.x-dev -> satisfiable by sitrunlab/learnzf2[0.2.x-dev].
    - sitrunlab/learnzf2 0.2.x-dev requires doctrine/doctrine-migrations-module dev-master -> no matching package found.

Potential causes:
 - A typo in the package name
 - The package is not available in a stable-enough version according to your minimum-stability setting
   see <https://groups.google.com/d/topic/composer-dev/_g3ASeIFlrc/discussion> for more details.

@samsonasik
Copy link
Contributor

oh, seems i need minimum-stability...

@samsonasik
Copy link
Contributor

@gianarb it seems https://github.com/gianarb/DoctrineMigrationsModule is not composer-able to install yet...

@gianarb
Copy link
Contributor Author

gianarb commented May 18, 2015

In this moment doctrineMigrations has not tag.. In this moment this feature is freezed because I wait feedback about this issue :) gianarb/DoctrineMigrationsModule#2

@samsonasik
Copy link
Contributor

I will try git clone, wait a minute

@samsonasik
Copy link
Contributor

@gianarb i re-tried and got error :

PHP Fatal error:  Class 'DoctrineMigrationsModule\Service\MigrationsCommandFactory' not found in /Users/samsonasik/www/LearnZF2/vendor/doctrine/doctrine-module/src/DoctrineModule/ServiceFactory/AbstractDoctrineServiceFactory.php on line 57

it seems my dependency just not uptodate. I'm basically +1 for it.

@codeliner
Copy link

@samsonasik What do you think about the issues mentioned in gianarb/DoctrineMigrationsModule#2?

@gianarb
Copy link
Contributor Author

gianarb commented May 20, 2015

DoctrineORMModule will maintain doctrine\migrations..
https://twitter.com/GianArb/status/601072388982362112

:) Thanks

@gianarb gianarb closed this May 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Break Enhacement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants