Fix for alternate entity managers in cli (Issue #58). #75
Conversation
|
Can you check this on all commands with travis? see |
| @@ -90,10 +93,20 @@ public function onBootstrap(EventInterface $e) | |||
| new VersionCommand(), | |||
| )); | |||
|
|
|||
| $allCommands = $cli->all('orm'); | |||
| foreach($allCommands as $cmd) { | |||
There was a problem hiding this comment.
Not sure I like the solution, plus we need a more unique parameter instead of --em. Please add the tests if possible
There was a problem hiding this comment.
I was also torn on this solution, but the alternative was to write a HelperSet for the ServiceManager and add wrappers for all commands. The wrappers would extend off of an abstract class that would read the InputStream, take the ServiceManager and pull the appropriate EntityManager and Connection.
There was a problem hiding this comment.
I think a single wrapper could work if you override the configure method and proxy all other calls to the wrapped command...
There was a problem hiding this comment.
Something like
<?php
class MyCommandWrapper implements Command
{
public function __construct(Command $command, ServiceLocatorInterface $sl) {}
public function configure()
{
$this->command->configure();
$this->addOption(...);
}
// proxy remaining methods
}
ghost
assigned
|
@brettalewis ping |
|
(also, a rebase is needed) |
| /* @var $sm ServiceLocatorInterface */ | ||
| $sm = $e->getParam('ServiceManager'); | ||
| /* @var $em \Doctrine\ORM\EntityManager */ | ||
| $em = $sm->get('doctrine.entitymanager.orm_default'); | ||
| $em = $sm->get('doctrine.entitymanager.' . $emName); |
There was a problem hiding this comment.
Also here, wouldn't enforce any prefix.
|
Opened #97 instead |
I didn't realize I couldn't easily connect these, so I'm referencing the issue here.